fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically #8983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason918
reviewed
Nov 28, 2024
Ok, I'll add the unit test as soon as possible. Thanks! |
I have added a unit test for it, looking forward to your review. |
|
@AuroraTwinkle Please check the CI result. |
Sorry, I have fixed it! And the CI has passed in my fork repo. |
|
@lizhanhui Hi, looking forward to your review, thanks. |
lizhimins
approved these changes
Dec 14, 2024
|
@lizhanhui @Jason918 @lizhimins Would you please merge this PR?Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
The #6426 has fixed topicConfig update atomic problem, but the SubscriptionGroupConfig and MessageRequestMode has not been fixed. So I submit a PR to fix them!
Brief Description
How Did You Test This Change?