Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8651] Fix revive topic process lag metric calculation #8652

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Sep 5, 2024

Which Issue(s) This PR Fixes

Fixes #8651

Brief Description

Lag is maxQueueOffset plus nextPullOffset

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.20%. Comparing base (0b0f8ec) to head (bc8b319).

Files with missing lines Patch % Lines
...he/rocketmq/broker/processor/PopReviveService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8652      +/-   ##
=============================================
- Coverage      47.26%   47.20%   -0.06%     
+ Complexity     11487    11470      -17     
=============================================
  Files           1277     1277              
  Lines          89432    89432              
  Branches       11502    11502              
=============================================
- Hits           42272    42220      -52     
- Misses         41953    41997      +44     
- Partials        5207     5215       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Fix revive topic process lag metric value
2 participants