[ISSUE #7491] metricsExporterType enum config support #7492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeCarf
reviewed
Oct 24, 2023
Codecov Report
@@ Coverage Diff @@
## develop #7492 +/- ##
=============================================
- Coverage 42.97% 42.97% -0.01%
Complexity 9669 9669
=============================================
Files 1161 1161
Lines 83933 83952 +19
Branches 10898 10899 +1
=============================================
+ Hits 36068 36076 +8
- Misses 43392 43405 +13
+ Partials 4473 4471 -2
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
ping @fuyou001 for review |
|
ping @RongtongJin for review |
|
ping @xdkxlk for review |
|
ping @francisoliverlee for review |
|
ping @lizhimins for reivew |
|
resolved by #7705 |
|
resolved by #7697 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7491
Brief Description
config file using
MixAll.properties2Objectto load not support enum type. so add aStringarg oneHow Did You Test This Change?
after this change, metric port listen appear as expect