[improve][broker] Add dedicated partition configuration for system topics to reduce resource usage #23785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…educe resource consumption
…educe resource consumption
dao-jun
approved these changes
Dec 30, 2024
…educe resource consumption
|
LGTM |
HQebupt
approved these changes
Jan 3, 2025
|
/pulsarbot rerun-failure-checks |
|
Please rename the title of this PR since it's currently misleading. |
|
/pulsarbot rerun-failure-checks |
lhotari
changed the title
lhotari
reviewed
Jan 3, 2025
…educe resource consumption
|
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23785 +/- ##
============================================
+ Coverage 73.57% 74.16% +0.59%
+ Complexity 32624 2376 -30248
============================================
Files 1877 1853 -24
Lines 139502 143471 +3969
Branches 15299 16292 +993
============================================
+ Hits 102638 106406 +3768
+ Misses 28908 28675 -233
- Partials 7956 8390 +434
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
requested changes
Jan 7, 2025
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
…educe resource consumption
|
@lhotari Hello, please help me review |
HQebupt
approved these changes
Jan 9, 2025
|
/pulsarbot rerun-failure-checks |
|
@lhotari hello,please help me review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The number of partitions for creating system topics depends on the value of the "defaultNumPartitions" configuration field, but this field is also the number of partitions for automatically creating topics. If the value of defaultNumPartitions is set to a large value, the system theme partition is also large, causing resource waste.
Modifications
New "systemTopicDefaultNumPartitions" configuration field, isolation system topic creation and automatically create topic for "defaultNumPartitions" fields of mutual dependence. When metadata is mounted, the system topic and common topic depend on the default partition configuration parameters
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: