[improve][client]Add logging for message size exceeding the configured threshold before throwing exception #23681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red maximum size.
nodece
approved these changes
Dec 5, 2024
Technoboy-
reviewed
Dec 6, 2024
| // Log the message size exceeding the limit | ||
| log.warn("Message size exceeded: Producer {} attempted to send a message of {} bytes, " | ||
| + "exceeding the configured maximum size of {} bytes on topic {}.", | ||
| producerName, messageSize, maxMessageSize, topic); |
There was a problem hiding this comment.
Seems useless for this log, the client could get the exception with log below.
There was a problem hiding this comment.
+1, the exception can be propagated to the send oeration.
|
There doesn't seem to be a need to log this since it's already part of the exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current behavior does not provide clear visibility when the message size exceeds the configured maximum size, often leading to
InvalidMessageExceptionerror. This change introduces a log statement to notify when the message size exceeds the threshold, helping users identify and troubleshoot message size issues more easily.Modifications
Added a
log.warnstatement before releasing the semaphore and throwing theInvalidMessageException.The log includes details about the message size, the configured threshold, and the producer/topic involved, improving visibility for debugging and troubleshooting.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete