Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala-steward.yml to latest ubuntu image. #1642

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

counter2015
Copy link
Contributor

This PR makes scala-steward github action to run on ubuntu-latest and install sbt before running.

see:
actions/runner-images#10636
scala-steward-org/scala-steward-action#644

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin
Copy link
Member

He-Pin commented Dec 30, 2024

@counter2015 Thank you

@He-Pin
Copy link
Member

He-Pin commented Dec 30, 2024

@counter2015 Would you like to submit the same change to pekko-* projects?

@He-Pin He-Pin merged commit 136319f into apache:main Dec 30, 2024
8 checks passed
He-Pin pushed a commit to He-Pin/incubator-pekko that referenced this pull request Dec 30, 2024
@counter2015
Copy link
Contributor Author

@counter2015 Would you like to submit the same change to pekko-* projects?

let me check it later this week.

@pjfanning
Copy link
Contributor

@counter2015 Would you like to submit the same change to pekko-* projects?

let me check it later this week.

I would prefer if we don't do more of these PRs. CI changes are dangerous. Malicious agents could try to sneak in malicious build changes. Upgrading Ubuntu is not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants