HDDS-11991. Use picocli built-in for missing subcommand of GenericCli #7635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
GenericCli
does not need to implementCallable
only for showing "incomplete command". The same functionality is provided by picocli.Callable
in subclasses where missing. ImplementRunnable
wherecall()
does not throw checked exceptions.MissingSubcommandException
, no longer used.GetUserInfoHandler
, picocli does it for us.missingSubcommand
method fromGenericCli
, no longer used.https://issues.apache.org/jira/browse/HDDS-11991
How was this patch tested?
Tested
GetUserInfoHandler
without arguments:Acceptance test covers
GenericCli
without subcommand (for top-level commandozone admin
).CI:
https://github.com/adoroszlai/ozone/actions/runs/12595048598