KAFKA-7776: Tests for ISO8601 in Connect value parsing #18374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
connect
tests
kirktrue
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thanks for the PR @AndrewJSchofield.
I didn't want to rubber stamp it, so I dug in a bit to see if I could generate the value of currentMillis using the java.time APIs. I'm sure it's possible, but I didn't find it after about 15 minutes of trying. It's also very likely that the code to do so would be much more opaque than what's there now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This old issue originally documented a problem with handling ISO8601 dates and times in the Kafka Connect value parsing. Since that time, the parsing has been fixed, but the tests which avoided the erroneous behaviour were not added. The tests have been adjusted as a result.
Committer Checklist (excluded from commit message)