Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR Remove needs-attention label after review #18366

Merged
merged 6 commits into from
Jan 9, 2025
Merged

MINOR Remove needs-attention label after review #18366

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de2f33e
also remove needs-attention label
mumrah Dec 31, 2024
f347c0b
add log line
mumrah Dec 31, 2024
3d9bf24
quote the label name
mumrah Dec 31, 2024
6892d88
remove unnecessary logging
mumrah Jan 2, 2025
d8dffbe
search for needs-attention separately
mumrah Jan 4, 2025
8081077
restructure workflows a bit
mumrah Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/pr-reviewed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ on:
jobs:
remove-triage:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the changes introduced by this PR, we may need to consider renaming this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I realized the workflow file names are a bit incorrect too, so I rearranged some things. PTAL

runs-on: ubuntu-latest
strategy:
matrix:
label: [triage, needs-attention]
steps:
- name: Env
run: printenv
Expand All @@ -35,8 +38,9 @@ jobs:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
console.log("Finding PRs with label '${{ matrix.label }}'");
github.paginate("GET /search/issues{?q}", {
q: "repo:apache/kafka label:triage is:pull-request"
q: "repo:apache/kafka label:${{ matrix.label }} is:pull-request"
})
.then((pulls) => {
pulls.forEach(pull => {
Expand All @@ -50,12 +54,12 @@ jobs:
}).then((resp) => {
console.log("Found " + resp.data.length + " reviews for PR " + pull.number);
if (resp.data.length > 0) {
console.log("Removing 'triage' label from PR " + pull.number + " : " + pull.title);
console.log("Removing '${{ matrix.label }}' label from PR " + pull.number + " : " + pull.title);
github.rest.issues.removeLabel({
owner: "apache",
repo: "kafka",
issue_number: pull.number,
name: "triage"
name: "${{ matrix.label }}"
});
}
});
Expand Down
Loading