Introduce MissingRequiredFilesToDeleteException for Streaming Deletes
#11887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new exception, `MissingRequiredFilesToDeleteException`, to allow users to inspect missing file details during streaming deletes. - This exception extends `ValidationException` and preserves compatibility with the existing validation message. - Users can now retrieve missing file locations via the `getMissingLocations()` method, instead of relying solely on the exception message.
|
I think generally we wouldn't want to introduce new API concepts unless there is some usage of that API within the core library itself (Otherwise we are basically just opening up technical debt without tests or benefit). Do we have plans for introducing a usage in the repo somewhere? At minimum I think we would want tests utilizing this API but I think a practical application would also be required as a justification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new exception,
MissingRequiredFilesToDeleteException, to allow usersto inspect missing file details during streaming deletes.
ValidationExceptionand preserves compatibilitywith the existing validation message.
getMissingLocations()method, instead of relying solely on the exception message.