Kafka-connect-runtime: remove code duplications in integration tests #11883
+142
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanck
reviewed
Jan 1, 2025
| @ParameterizedTest | ||
| @NullSource | ||
| @ValueSource(strings = "test_branch") | ||
| public void testIcebergSink(String branch) { | ||
| // partitioned table | ||
| catalog().createTable(TABLE_IDENTIFIER1, TestEvent.TEST_SCHEMA, TestEvent.TEST_SPEC); | ||
| // unpartitioned table | ||
| // non-partitioned table |
There was a problem hiding this comment.
We use "unpartitioned" throughout the Iceberg code, so please revert this change.
There was a problem hiding this comment.
sorry, didn't know that. reverted
bryanck
reviewed
Jan 2, 2025
| } | ||
|
|
||
| @AfterEach | ||
| public void baseAfter() { | ||
| context().stopConnector(connectorName()); | ||
| deleteTopic(testTopic()); | ||
| catalog().dropTable(TableIdentifier.of(TEST_DB, TEST_TABLE1)); |
There was a problem hiding this comment.
I feel the drop table belongs in the subclass.
|
Thanks @wombatu-kun , it mostly looks good, I added a couple of comments. |
wombatu-kun
force-pushed
the
kafka-connect-runtime-integration-tests-refactoring
branch
from
d82e94f to
1772bef
Compare
bryanck
reviewed
Jan 2, 2025
| @@ -55,6 +61,19 @@ public class IntegrationTestBase { | |||
| private KafkaProducer<String, String> producer; | |||
|
|
|||
| protected static final int TEST_TOPIC_PARTITIONS = 2; | |||
| protected static final String TEST_DB = "test"; | |||
| protected static final String TEST_TABLE1 = "foobar1"; | |||
There was a problem hiding this comment.
I feel we should keep the table name constants in the subclasses as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a lot of code duplicates in integration tests of module
iceberg-kafka-connect-runtime. I propose to avoid such code duplication by making parent classIntegrationTestBaseabstract and move all common logic (beforeEach, afterEach, creating kafka common config, running test, asserting snapshot is added) fromIntegrationTest,IntegrationMultiTableTestandIntegrationDynamicTableTesttoIntegrationTestBase.