Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37174][sql-client] Fix failed tests about SqlClientTest#testPrintAllModeHelp and #testPrintEmbeddedModeHelp #26018

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

xuyangzhong
Copy link
Contributor

What is the purpose of the change

Fix failed tests about SqlClientTest#testPrintAllModeHelp and #testPrintEmbeddedModeHelp

Brief change log

  • Fix failed tests about SqlClientTest#testPrintAllModeHelp and #testPrintEmbeddedModeHelp

Verifying this change

This change added tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@xuyangzhong
Copy link
Contributor Author

@xaniasd @dianfu the pr #25541 seems to break the ci, and this pr tries to fix it. Can you take a look at this one?

…intAllModeHelp and #testPrintEmbeddedModeHelp
@flinkbot
Copy link
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xuyangzhong
Copy link
Contributor Author

@dianfu dianfu merged commit 1afe645 into apache:master Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants