refactor(label): restore direct label set to avoid unnecessary if

apache · Nov 7, 2024 · 8126d2f · 8126d2f
1 parent a70819c
commit 8126d2f
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/label/LabelManager.ts b/src/label/LabelManager.ts
@@ -364,6 +364,7 @@ class LabelManager {
                 needsUpdateLabelLine = true;
             }
             else {
+                label.x = defaultLabelAttr.x;
                 label.setStyle('x', defaultLabelAttr.style.x);
             }
 
@@ -373,6 +374,7 @@ class LabelManager {
                 needsUpdateLabelLine = true;
             }
             else {
+                label.y = defaultLabelAttr.y;
                 label.setStyle('y', defaultLabelAttr.style.y);
             }
 
@@ -393,16 +395,10 @@ class LabelManager {
                 if (layoutOption.x != null) {
                     labelState.x = parsePercent(layoutOption.x, width);
                 }
-                else if (isNormal) {
-                    labelState.x = defaultLabelAttr.x;
-                }
 
                 if (layoutOption.y != null) {
                     labelState.y = parsePercent(layoutOption.y, height);
                 }
-                else if (isNormal) {
-                    labelState.y = defaultLabelAttr.y;
-                }
 
                 if (layoutOption.align != null) {
                     labelState.style = labelState.style || {};