Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement][nereids]implement showTabletIdCommand in nereids #46321

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[Enhancement][nereids]implement showTabletIdCommand in nereids #46321

wants to merge 9 commits into from
+259 −1

Conversation

deng-jeffer
Copy link

@deng-jeffer deng-jeffer commented Jan 2, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42757

Related PR:
No

Problem Summary:
implement showTabletIdCommand in nereids

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor

run buildall

@deng-jeffer
Copy link
Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32585 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ad26be6d51f8189ec4de87df2afd384a416aefa3, data reload: false

------ Round 1 ----------------------------------
q1	17732	6166	6037	6037
q2	2048	292	160	160
q3	10435	1251	771	771
q4	10203	864	428	428
q5	7504	2138	1999	1999
q6	212	180	150	150
q7	891	769	596	596
q8	9237	1354	1145	1145
q9	5278	4890	4902	4890
q10	6764	2311	1855	1855
q11	499	276	247	247
q12	342	352	215	215
q13	17754	3682	3040	3040
q14	241	243	222	222
q15	568	508	506	506
q16	628	631	584	584
q17	576	849	332	332
q18	6807	6443	6316	6316
q19	1950	971	560	560
q20	304	313	184	184
q21	2983	2227	2036	2036
q22	358	337	312	312
Total cold run time: 103314 ms
Total hot run time: 32585 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6345	6208	6243	6208
q2	239	325	232	232
q3	2251	2648	2298	2298
q4	1458	1785	1369	1369
q5	4370	4749	5028	4749
q6	189	179	145	145
q7	2058	1952	1792	1792
q8	2631	2865	2702	2702
q9	7276	7201	7235	7201
q10	3087	3349	2829	2829
q11	570	532	507	507
q12	731	736	619	619
q13	3479	3882	3202	3202
q14	283	325	277	277
q15	581	532	518	518
q16	681	665	627	627
q17	1199	1736	1254	1254
q18	7694	7495	7452	7452
q19	830	1151	1049	1049
q20	2021	2049	1859	1859
q21	5803	5360	4792	4792
q22	651	596	587	587
Total cold run time: 54427 ms
Total hot run time: 52268 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196585 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ad26be6d51f8189ec4de87df2afd384a416aefa3, data reload: false

query1	1333	967	909	909
query2	6397	2278	2222	2222
query3	10959	4683	4659	4659
query4	33296	23693	23364	23364
query5	4529	619	444	444
query6	290	201	184	184
query7	3977	501	297	297
query8	313	251	228	228
query9	9545	2668	2656	2656
query10	473	308	244	244
query11	18162	15256	15099	15099
query12	165	106	101	101
query13	1638	549	399	399
query14	10289	7347	7506	7347
query15	264	212	192	192
query16	7952	593	477	477
query17	1543	792	592	592
query18	2134	422	331	331
query19	219	222	164	164
query20	127	113	113	113
query21	212	126	108	108
query22	4677	4521	4546	4521
query23	34334	33774	33644	33644
query24	6332	2288	2421	2288
query25	488	480	396	396
query26	728	285	151	151
query27	2106	466	340	340
query28	5245	2481	2471	2471
query29	632	564	427	427
query30	242	182	151	151
query31	986	917	879	879
query32	81	60	61	60
query33	468	335	304	304
query34	770	857	496	496
query35	802	830	763	763
query36	1019	1084	972	972
query37	123	102	75	75
query38	4322	4525	4157	4157
query39	1530	1453	1476	1453
query40	211	116	105	105
query41	46	46	42	42
query42	121	104	100	100
query43	512	513	507	507
query44	1341	827	824	824
query45	185	174	164	164
query46	884	1063	652	652
query47	1983	2041	1930	1930
query48	382	428	339	339
query49	709	475	408	408
query50	644	678	395	395
query51	7238	7304	7129	7129
query52	111	102	94	94
query53	236	257	182	182
query54	485	500	409	409
query55	84	79	77	77
query56	266	264	242	242
query57	1300	1217	1134	1134
query58	237	221	220	220
query59	3110	3304	3123	3123
query60	281	269	248	248
query61	125	106	118	106
query62	883	826	768	768
query63	241	196	187	187
query64	3122	1048	658	658
query65	3358	3338	3268	3268
query66	783	443	307	307
query67	16389	15855	15527	15527
query68	8475	704	516	516
query69	481	312	263	263
query70	1217	1132	1130	1130
query71	450	294	253	253
query72	6304	3907	3824	3824
query73	654	749	355	355
query74	10160	9029	9052	9029
query75	3890	3126	2662	2662
query76	3688	1179	779	779
query77	768	352	272	272
query78	10473	10399	9468	9468
query79	3209	815	583	583
query80	610	505	444	444
query81	498	265	226	226
query82	563	148	118	118
query83	157	167	145	145
query84	233	84	71	71
query85	790	351	300	300
query86	402	299	280	280
query87	4550	4433	4480	4433
query88	4615	2161	2137	2137
query89	411	331	286	286
query90	1780	184	181	181
query91	126	135	106	106
query92	64	54	52	52
query93	1908	865	524	524
query94	653	390	280	280
query95	325	254	248	248
query96	482	603	277	277
query97	2852	2985	2868	2868
query98	225	216	200	200
query99	1459	1584	1452	1452
Total cold run time: 296441 ms
Total hot run time: 196585 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.54 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ad26be6d51f8189ec4de87df2afd384a416aefa3, data reload: false

query1	0.04	0.05	0.03
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.63	0.10	0.10
query5	0.41	0.42	0.40
query6	1.18	0.66	0.66
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.50	0.51
query10	0.55	0.56	0.53
query11	0.15	0.10	0.10
query12	0.15	0.12	0.11
query13	0.61	0.59	0.60
query14	2.75	2.75	2.84
query15	0.88	0.83	0.82
query16	0.38	0.38	0.38
query17	1.02	1.04	1.01
query18	0.24	0.22	0.21
query19	1.88	1.80	2.00
query20	0.02	0.01	0.01
query21	15.35	0.93	0.61
query22	0.74	0.90	0.65
query23	15.22	1.36	0.51
query24	3.58	1.38	1.29
query25	0.25	0.18	0.10
query26	0.23	0.14	0.13
query27	0.05	0.06	0.04
query28	14.15	1.49	1.05
query29	12.60	3.91	3.21
query30	0.24	0.09	0.06
query31	2.83	0.60	0.39
query32	3.23	0.54	0.46
query33	3.19	3.18	3.14
query34	16.75	5.09	4.49
query35	4.50	4.46	4.48
query36	0.65	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.95 s
Total hot run time: 31.54 s

@deng-jeffer
Copy link
Author

@starocean999 hello,can you tell me ,how fix [External Regression] test?

@deng-jeffer
Copy link
Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32807 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6bfdaef9fe8102d8eba8b8a1cd3e486e9f91bc16, data reload: false

------ Round 1 ----------------------------------
q1	17583	6126	6047	6047
q2	2051	327	194	194
q3	10385	1214	753	753
q4	10228	864	434	434
q5	8159	2140	2013	2013
q6	203	185	146	146
q7	900	744	596	596
q8	9227	1379	1173	1173
q9	5147	4920	4900	4900
q10	6756	2267	1855	1855
q11	473	272	256	256
q12	346	355	222	222
q13	18036	3649	3137	3137
q14	240	237	225	225
q15	570	500	505	500
q16	648	599	607	599
q17	592	860	343	343
q18	7345	6716	6380	6380
q19	1670	961	553	553
q20	309	328	191	191
q21	2881	2246	1979	1979
q22	365	343	311	311
Total cold run time: 104114 ms
Total hot run time: 32807 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6261	6214	6213	6213
q2	234	326	234	234
q3	2283	2672	2288	2288
q4	1450	1813	1412	1412
q5	4313	4735	4820	4735
q6	185	175	146	146
q7	2063	1992	1803	1803
q8	2625	2810	2691	2691
q9	7257	7207	7273	7207
q10	3059	3336	2745	2745
q11	566	510	497	497
q12	687	826	606	606
q13	3470	3885	3280	3280
q14	286	315	270	270
q15	561	521	521	521
q16	667	665	637	637
q17	1210	1734	1250	1250
q18	7677	7541	7353	7353
q19	836	1054	1122	1054
q20	2016	2015	1881	1881
q21	5737	5035	4979	4979
q22	632	639	608	608
Total cold run time: 54075 ms
Total hot run time: 52410 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193943 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6bfdaef9fe8102d8eba8b8a1cd3e486e9f91bc16, data reload: false

query1	1309	955	926	926
query2	6474	2394	2344	2344
query3	10965	4622	4701	4622
query4	33025	23465	23160	23160
query5	4571	616	441	441
query6	286	212	190	190
query7	3975	481	297	297
query8	292	257	237	237
query9	9487	2633	2638	2633
query10	474	314	240	240
query11	17816	15103	15019	15019
query12	160	109	108	108
query13	1557	512	390	390
query14	10542	6962	6962	6962
query15	233	220	182	182
query16	7821	600	478	478
query17	1484	761	588	588
query18	2079	406	294	294
query19	216	187	155	155
query20	122	118	116	116
query21	213	138	107	107
query22	4507	4448	4270	4270
query23	34609	33052	33085	33052
query24	6521	2409	2265	2265
query25	486	439	394	394
query26	814	291	173	173
query27	1961	469	332	332
query28	5725	2413	2426	2413
query29	565	568	425	425
query30	220	183	155	155
query31	978	880	807	807
query32	71	62	57	57
query33	509	371	305	305
query34	757	845	502	502
query35	798	826	727	727
query36	1000	1033	920	920
query37	121	100	73	73
query38	4138	4137	4199	4137
query39	1479	1464	1468	1464
query40	212	121	119	119
query41	52	54	51	51
query42	119	104	102	102
query43	510	525	500	500
query44	1406	807	847	807
query45	197	189	172	172
query46	866	1049	647	647
query47	1895	1906	1827	1827
query48	409	408	321	321
query49	720	496	402	402
query50	641	655	404	404
query51	7092	7033	6818	6818
query52	100	101	97	97
query53	223	257	187	187
query54	499	514	473	473
query55	84	79	82	79
query56	273	280	250	250
query57	1224	1209	1136	1136
query58	250	244	242	242
query59	3163	3114	3082	3082
query60	309	287	276	276
query61	144	140	180	140
query62	847	786	719	719
query63	227	197	185	185
query64	3093	1047	670	670
query65	3280	3256	3225	3225
query66	891	412	321	321
query67	16130	15857	15440	15440
query68	7385	707	515	515
query69	475	293	258	258
query70	1187	1104	1110	1104
query71	439	272	253	253
query72	6475	3881	3819	3819
query73	659	738	353	353
query74	10222	9168	8947	8947
query75	4149	3131	2670	2670
query76	3675	1150	766	766
query77	783	362	269	269
query78	10079	9974	9286	9286
query79	3610	802	575	575
query80	586	581	433	433
query81	505	275	235	235
query82	677	151	115	115
query83	159	162	148	148
query84	248	89	72	72
query85	775	344	290	290
query86	392	303	297	297
query87	4302	4427	4394	4394
query88	4716	2146	2127	2127
query89	415	331	298	298
query90	1746	187	189	187
query91	133	141	113	113
query92	61	54	56	54
query93	2063	888	524	524
query94	647	398	289	289
query95	325	257	246	246
query96	497	621	275	275
query97	2808	2972	2790	2790
query98	223	215	200	200
query99	1527	1506	1389	1389
Total cold run time: 295159 ms
Total hot run time: 193943 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6bfdaef9fe8102d8eba8b8a1cd3e486e9f91bc16, data reload: false

query1	0.04	0.05	0.04
query2	0.07	0.03	0.03
query3	0.23	0.08	0.06
query4	1.62	0.10	0.10
query5	0.42	0.42	0.41
query6	1.18	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.51	0.50
query10	0.56	0.56	0.55
query11	0.15	0.10	0.11
query12	0.14	0.10	0.11
query13	0.62	0.60	0.61
query14	2.72	2.73	2.73
query15	0.90	0.83	0.82
query16	0.39	0.38	0.40
query17	0.98	0.99	1.02
query18	0.24	0.21	0.22
query19	1.87	1.87	1.98
query20	0.02	0.01	0.01
query21	15.35	0.97	0.60
query22	0.76	0.88	0.68
query23	15.17	1.35	0.60
query24	2.86	1.31	1.65
query25	0.20	0.17	0.07
query26	0.24	0.16	0.14
query27	0.05	0.05	0.05
query28	13.98	1.49	1.05
query29	12.61	3.92	3.25
query30	0.25	0.09	0.06
query31	2.84	0.58	0.37
query32	3.24	0.55	0.46
query33	3.11	3.15	3.29
query34	16.63	5.09	4.49
query35	4.45	4.48	4.48
query36	0.82	0.47	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.14
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.87 s
Total hot run time: 31.75 s

@deng-jeffer
Copy link
Author

run feut

@deng-jeffer
Copy link
Author

run p0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement showTabletIdCommand in nereids
4 participants
@deng-jeffer @hello-stephen @starocean999 @doris-robot