Support extraPorts in the service template. #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
At Budibase we're making use of the CouchDB structured query service (SQS) and as such need to communicate with the SQS binary running alongside CouchDB on port 4984. We've created our own
budibase/couchdb
image to run SQS alongside CouchDB.To allow this, I've added two new options to
values.yaml
:extraPorts
-- to specify new ports to expose on theStatefulSet
pods.service.extraPorts
-- to specify new ports to expose on theService
.Special notes for your reviewer:
Before starting on this PR I ran
make test
and the tests passed. Now, though, when I run them I get the following error:I'm not sure what I'm doing wrong, help would be appreciated 🙏
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.