Refactor.

apache · Jan 24, 2021 · b6bca11 · b6bca11
1 parent 2bd243b
commit b6bca11
Showing 1 changed file with 13 additions and 15 deletions.
diff --git a/src/test/java/org/apache/commons/io/IOUtilsTestCase.java b/src/test/java/org/apache/commons/io/IOUtilsTestCase.java
@@ -509,33 +509,31 @@ public void testContentEquals_InputStream_InputStream() throws Exception {
         {
             assertTrue(IOUtils.contentEquals((InputStream) null, null));
         }
+        final byte[] dataEmpty = "".getBytes(StandardCharsets.UTF_8);
+        final byte[] dataAbc = "ABC".getBytes(StandardCharsets.UTF_8);
+        final byte[] dataAbcd = "ABCD".getBytes(StandardCharsets.UTF_8);
         {
-            final ByteArrayInputStream input1 = new ByteArrayInputStream("".getBytes(StandardCharsets.UTF_8));
+            final ByteArrayInputStream input1 = new ByteArrayInputStream(dataEmpty);
             assertFalse(IOUtils.contentEquals(input1, null));
         }
         {
-            final ByteArrayInputStream input1 = new ByteArrayInputStream("".getBytes(StandardCharsets.UTF_8));
+            final ByteArrayInputStream input1 = new ByteArrayInputStream(dataEmpty);
             assertFalse(IOUtils.contentEquals(null, input1));
         }
         {
-            final ByteArrayInputStream input1 = new ByteArrayInputStream("".getBytes(StandardCharsets.UTF_8));
+            final ByteArrayInputStream input1 = new ByteArrayInputStream(dataEmpty);
             assertTrue(IOUtils.contentEquals(input1, input1));
         }
         {
-            final ByteArrayInputStream input1 = new ByteArrayInputStream("ABC".getBytes(StandardCharsets.UTF_8));
+            final ByteArrayInputStream input1 = new ByteArrayInputStream(dataAbc);
             assertTrue(IOUtils.contentEquals(input1, input1));
         }
-        assertTrue(IOUtils.contentEquals(new ByteArrayInputStream("".getBytes(StandardCharsets.UTF_8)),
-            new ByteArrayInputStream("".getBytes(StandardCharsets.UTF_8))));
-        assertTrue(IOUtils.contentEquals(
-            new BufferedInputStream(new ByteArrayInputStream("".getBytes(StandardCharsets.UTF_8))),
-            new BufferedInputStream(new ByteArrayInputStream("".getBytes(StandardCharsets.UTF_8)))));
-        assertTrue(IOUtils.contentEquals(new ByteArrayInputStream("ABC".getBytes(StandardCharsets.UTF_8)),
-            new ByteArrayInputStream("ABC".getBytes(StandardCharsets.UTF_8))));
-        assertFalse(IOUtils.contentEquals(new ByteArrayInputStream("ABCD".getBytes(StandardCharsets.UTF_8)),
-            new ByteArrayInputStream("ABC".getBytes(StandardCharsets.UTF_8))));
-        assertFalse(IOUtils.contentEquals(new ByteArrayInputStream("ABC".getBytes(StandardCharsets.UTF_8)),
-            new ByteArrayInputStream("ABCD".getBytes(StandardCharsets.UTF_8))));
+        assertTrue(IOUtils.contentEquals(new ByteArrayInputStream(dataEmpty), new ByteArrayInputStream(dataEmpty)));
+        assertTrue(IOUtils.contentEquals(new BufferedInputStream(new ByteArrayInputStream(dataEmpty)),
+            new BufferedInputStream(new ByteArrayInputStream(dataEmpty))));
+        assertTrue(IOUtils.contentEquals(new ByteArrayInputStream(dataAbc), new ByteArrayInputStream(dataAbc)));
+        assertFalse(IOUtils.contentEquals(new ByteArrayInputStream(dataAbcd), new ByteArrayInputStream(dataAbc)));
+        assertFalse(IOUtils.contentEquals(new ByteArrayInputStream(dataAbc), new ByteArrayInputStream(dataAbcd)));
         // Tests with larger inputs that DEFAULT_BUFFER_SIZE in case internal buffers are used.
         final byte[] bytes2XDefaultA = new byte[IOUtils.DEFAULT_BUFFER_SIZE * 2];
         final byte[] bytes2XDefaultB = new byte[IOUtils.DEFAULT_BUFFER_SIZE * 2];