CASSSIDECAR-151: Adds sidecar endpoint for node decommissioning operation #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoppu22
reviewed
Nov 13, 2024
| @@ -111,6 +111,10 @@ public final class ApiEndpointsV1 | |||
|
|
|||
| public static final String CONNECTED_CLIENT_STATS_ROUTE = API_V1 + CASSANDRA + "/stats/connected-clients"; | |||
|
|
|||
| public static final String LIST_JOBS_ROUTE = API_V1 + CASSANDRA + "/jobs"; | |||
| public static final String JOB_STATUS_ROUTE = API_V1 + CASSANDRA + "/jobs/" + JOB_ID_PATH_PARAM + "/status"; | |||
| public static final String NODE_DECOMMISSION_ROUTE = API_V1 + CASSANDRA + "/node/decommission"; | |||
There was a problem hiding this comment.
We are using management in the prefix, for example /api/v1/cassandra/management/node/decommission for JMX and nodetool operations. IIRC, we discussed this during Sidecar's JMX APIs design meeting
There was a problem hiding this comment.
Right, and I feel these are different from those (and we arrived at this design during the nodetool APIs review), as they are specific to the administrative node operations like decommission, repair, rebuild etc. We can converge on the URI offline if you'd like.
yifan-c
changed the title
arjunashok
force-pushed
the
CASSANDRASC-151
branch
from
93bf17b to
bf410ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are part of the effort to introduce bespoke Sidecar APIs to support key operational functionality currently managed through nodetool commands.
These changes specifically incorporate the node decommission functionality in a sidecar endpoint.
Update 12/19
Changes
api/v1/cassandra/node/decommissionDecommissionJob, which invokes the JMX API to triggerdecommissionoperation.