Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Clarify thread safety of Decoders returned by DecoderFactory. #3278

Merged
merged 1 commit into from
Jan 4, 2025
Merged

[Java] Clarify thread safety of Decoders returned by DecoderFactory. #3278

merged 1 commit into from
Jan 4, 2025

Conversation

belugabehr
Copy link
Contributor

The extra noise is from the spotless plugin.

@github-actions github-actions bot added the Java Pull Requests for Java binding label Jan 4, 2025
opwvhk
opwvhk requested changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@opwvhk opwvhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sensible addition. Thank you.

One request though, as the current choice of words looks odd. Can you please replace the first word ("while") with: "although"?

@belugabehr belugabehr force-pushed the belugabehr/thread-safe-factory-javadoc branch from 926f9e4 to f0c189f Compare January 4, 2025 19:03
@belugabehr
Copy link
Contributor Author

@opwvhk Done :)

@opwvhk opwvhk merged commit d26a327 into apache:main Jan 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opwvhk opwvhk opwvhk approved these changes

Assignees
No one assigned
Labels
Java Pull Requests for Java binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belugabehr @opwvhk