Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45151: [C++][Parquet] Fix Null-dereference READ in parquet::arrow::ListToSchemaField #45152

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Jan 2, 2025

Rationale for this change

Fix Null-dereference READ in parquet::arrow::ListToSchemaField

What changes are included in this PR?

Add a rule check before parquet::arrow::ListToSchemaField

Are these changes tested?

Yes

Are there any user-facing changes?

Bugfix

@mapleFU mapleFU requested a review from wgtmac as a code owner January 2, 2025 11:29
@mapleFU
Copy link
Member Author

mapleFU commented Jan 2, 2025

@pitrou @wgtmac @emkornfield

Copy link

github-actions bot commented Jan 2, 2025

⚠️ GitHub issue #45151 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mapleFU !

@pitrou
Copy link
Member

pitrou commented Jan 2, 2025

Is this one of the OSS-Fuzz issues @mapleFU ?

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 2, 2025
@mapleFU
Copy link
Member Author

mapleFU commented Jan 2, 2025

Is this one of the OSS-Fuzz issues

Yeah, recently it start to report a Null-deference problem, I just have time to handle this. I think all of parquet issue is this problem

cpp/src/parquet/arrow/arrow_schema_test.cc Outdated Show resolved Hide resolved
@mapleFU
Copy link
Member Author

mapleFU commented Jan 3, 2025

Will merge if ci pass

@mapleFU mapleFU merged commit 48d5151 into apache:main Jan 3, 2025
32 of 33 checks passed
@mapleFU mapleFU removed the awaiting committer review Awaiting committer review label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants