Alpha 5 release ready #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update pyndatic to 2.8 thanks @pyndatic team for the release https://pydantic.dev/articles/pydantic-v2-8-release
implements a version of search in the core package for all endpoints to use, this performs a number of cleanups: - removes unused search method signatures and merges them into core - updates enum with a generic signature that can be reused - updates test case for testing cardholder profiles - cleans up core to accept parameters as part of the internal get call refs #51
wires up the cardholder search to the cli, demonstrating use of the enums proper annotations for typer to spell out the options on the interface this should serve as the template to wire up almost all searches refs #13
first loged while i was trying to acknowledge multiple alarms, this adds support in the alarms cli for multiple arguments @tiangolo/typer makes this super simple to do. i will add a comment for reference so other endpoints know how to do this refs #55
uses to add confirmation messages for bulk operations preventing users making accidental errors
for non-interative operation of bulk updates via the api endpoints refs #55
copy paste error on my part where i deleted the get command when i was provisioning the delete
updates packages and installs email-validator for pyndatic EmailStr use, see next commmit for details
this comes to light as we integrated a custom gallagher mobile app where you don't end up using command centre to send out the invitation emails for branding and lifecycle reasons, same applies for sms messages this means that the invitation email will be empty and thus is being turned into an optional str, we are also moving to using EmailStr instead of just a string for validation
fixes the formatting so it's more in line with pep8
the enum definition didn't inherit from str and was thus not being recongised as a default value for the cli tool
initial thoughts on how i can run the cli and tui in a container this goes in line with publishing brew packages refs #33
the build was broken because the package wasn't being build and installed in the container, this fixes the issue, we must now refactor this to a two phase build to ensure nothing we don't need gets left behind in the container refs #33
i have cleaned up the dockerfile for the cli, don't see the point of a multistage image until the size or something else poses t to be a problem, please file or reopen #33 if this is a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.