Use TypedDicts rather than nested BaseModels #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feels tidier when all BaseModels maps directly to an actual input and/or output. The [typing_extensions][1] TypedDict is needed for Python < 3.12. Conveniently that package is already being installed as a Pydantic dependency. [1]: https://pypi.org/project/typing-extensions/
andreaso
force-pushed
the
typeddicts-vs-nested-basemodels
branch
from
fb86d45 to
a50d0c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feels tidier when all BaseModels maps directly to an actual input and/or output.
The typing_extensions TypedDict is needed for Python < 3.12. Conveniently that package is already being installed as a Pydantic dependency.