Feature/test docker build #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
commented
Aug 9, 2023
ClausKlein
force-pushed
the
feature/test-docker-build
branch
6 times, most recently
from
4ead609 to
f7b8f9e
Compare
aminya
reviewed
Aug 29, 2023
aminya
reviewed
Aug 29, 2023
aminya
requested changes
Aug 29, 2023
CMakeLists.txt
Outdated
Comment on lines
90
to
95
| ${ENABLE_SANITIZER_THREAD} | ||
| ${ENABLE_SANITIZER_MEMORY} |
There was a problem hiding this comment.
These sanitizers cannot be enabled with each other
There was a problem hiding this comment.
I thought this is handled by check_sanitizers_support()
see too ENABLE_SANITIZER_LEAK on Darwin
There was a problem hiding this comment.
check_sanitizers_support only checks if the compiler supports that variable. Maybe we should handle that as well.
.gitlab-ci.yml
Outdated
Comment on lines
16
to
18
| # XXX WHY? set time-zone | ||
| # TZ=Canada/Pacific | ||
| # ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone |
There was a problem hiding this comment.
As far as I remember, this is required for proper downloading of the tools
There was a problem hiding this comment.
see my gitlab pipline
ClausKlein
commented
Aug 29, 2023
Comment on lines
+49
to
+53
| - cmake --workflow --preset ${CI_compiler}-debug | ||
| - gcovr . | ||
| - cmake --workflow --preset ${CI_compiler}-release |
There was a problem hiding this comment.
usage example of cmake --workflow --preset
ClausKlein
force-pushed
the
feature/test-docker-build
branch
3 times, most recently
from
c4efb3c to
60b61b5
Compare
aminya
requested changes
Apr 4, 2024
Update docker related docu and config
Add simple CMakeWorkflowPresets
Try to use $env{CC} to control the compiler variant
Format CMakePresets files
Do not waste time, use run-clang-tidy
Upgrade project_options
Use cmake workflow on gitlab-ci
Update link to setup-cpp-x64-linux
Install current cmake version with pythone3-pip on CI
Cleanup .gitlab-ci.yml file
Use gcovr on gitlab-ci
Enable clang-tidy on CI builds Use custom-collapsible-sections
Use CI_compiler variable while build
As recommended in review
Update setup-cpp to v0.36.2 Upgrade to gcovr v6.0 Use newest cmake and project_options
ClausKlein
force-pushed
the
feature/test-docker-build
branch
from
70fa53c to
743901c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docker related docs and config
Update
.gitlab-ci.ymlfile usingcmake workflow presetsandgcovr.