Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I know you are not maintaining this package anymore,
But at least can you accept this change?
Your package is written using ES Module in the source, the new specs want developers to update their
package.json
to explicitly specify this (using"type": "module"
). This helps the node module resolver to find the right file to import inside a project that depends on your package. It also helps bundlers and other analyzer tools to properly include the file in the process.I also changed the property
main
because it pointed to the compiled version of your package which is incorrect. it has to point to the index file of your source in most case because that's what the node module resolver is looking for in an interconnected modules ecosystem.Without that people wanting to use your package inside their building process have to write:
This change will allow them to write: