WIP: community/php7: upgrade to 7.3.6

[bratkartoffel]

This PR updates PHP to the latest minor version (7.3.6).

A summary of the changes can be found at the php website: https://secure.php.net/manual/en/migration73.php

Changelogs:
https://secure.php.net/ChangeLog-7.php#7.3.0
https://secure.php.net/ChangeLog-7.php#7.3.1
https://secure.php.net/ChangeLog-7.php#7.3.2
https://secure.php.net/ChangeLog-7.php#7.3.3
https://secure.php.net/ChangeLog-7.php#7.3.4
https://secure.php.net/ChangeLog-7.php#7.3.5
https://secure.php.net/ChangeLog-7.php#7.3.6

[andypost]

This will make sense after 3.9 - some packages depends on php and can't work with 7.3

The goal for 3.9 release is #5569

[andypost]

Another 7.3 extensions checked:

• php7-pecl-apcu
• php7-pecl-msgpack
• php7-pecl-lzf

[bratkartoffel]

php7-pecl-amqp: Does not compile: php-amqp/php-amqp#337
php7-pecl-apcu: Needs patch
php7-pecl-ast: OK
php7-pecl-couchbase: OK
php7-pecl-event: OK
php7-pecl-gmagick: OK
php7-pecl-igbinary: OK
php7-pecl-imagick: Needs patch
php7-pecl-lzf: OK
php7-pecl-mailparse: Does not compile: https://bugs.php.net/bug.php?id=77045
php7-pecl-mcrypt: OK
php7-pecl-memcached: Needs update
php7-pecl-mongodb: Needs patch
php7-pecl-msgpack: OK
php7-pecl-oauth: Needs patch
php7-pecl-redis: OK
php7-pecl-ssh2: Does not compile: https://bugs.php.net/bug.php?id=77265
php7-pecl-timezonedb: OK
php7-pecl-xdebug: Needs update
php7-pecl-yaml: OK
php7-pecl-zmq: Does not compile: zeromq/php-zmq#193

[andypost]

php7-pecl-xdebug https://bugs.xdebug.org/view.php?id=1583

[andypost]

One more app 7.3 compatible #6684

[andypost]

Package php7-pear-auth_sasl could be removed as outdated https://pear.php.net/package/Auth_SASL @rnalrd

[andypost]

community/php7-pear-net_socket is not compatible with 7.3 #6708

[andypost]

community/php7-pear-mail_mime also need testing #6710

[andypost]

php-ssh2 should be ready for php 7.3 #6226

[TBK]

Would be great if this could be merged before 3.10.

[TBK]

btw 7.3.4 is out https://secure.php.net/ChangeLog-7.php#7.3.4

[TBK]

7.3.5 is out https://secure.php.net/ChangeLog-7.php#7.3.5

CI status: aarch64 fails because it hits timecap (1 hour).

[bratkartoffel]

@TBK Upgraded to 7.3.5 and rebased, thanks

[TBK]

Do we want all the static libs? https://pkgs.alpinelinux.org/contents?file=*.a&path=&name=php7-dev&branch=edge&arch=x86_64

If then I suggest we add a $pkgname-static subpkg.

[TBK]

Did not know of PR #7809 before writing my last comment.

[TBK]

3.7.6 is out https://secure.php.net/ChangeLog-7.php#7.3.6

[Ikke]

@bratkartoffel Is this still WIP?

[andypost]

@Ikke yes, waiting for 3.10 release

[captn3m0]

Ignore if I'm misunderstanding this, but does this mean Alpine 3.10 will ship with PHP 7.2?

7.2 Active Support is ending in December this year and 7.2 Security Support will run out before even 3.9 (by a few months). Keeping 7.2 in 3.10 will make this way worse.

[bratkartoffel]

Currently this PR is waiting on #5902 and #5905 to get merged. My tests so far are successfull, so I think that we can merge this into 3.10 soon.

[Ikke]

@bratkartoffel 3.10 will be branched any moment now (when 3.10 is released). At that point, it's not trivial anymore to get it into 3.10.

So I'll look at those PRs today to see if they can get get merged.

[ncopa]

I think we may need have pcre2-dev in depends_dev. I suggest this:

diff --git a/community/php7/APKBUILD b/community/php7/APKBUILD
index d11de41064..6de1f32eb8 100644
--- a/community/php7/APKBUILD
+++ b/community/php7/APKBUILD
@@ -37,7 +37,7 @@ url="https://secure.php.net"
 arch="all"
 license="PHP-3.01 BSD LGPL-2.0-or-later MIT Zend-2.0"
 depends="$pkgname-common"
-depends_dev="$pkgname=$pkgver-r$pkgrel autoconf pcre-dev"
+depends_dev="$pkgname=$pkgver-r$pkgrel autoconf pcre2-dev"
 # Most dependencies between extensions is auto-discovered (see _extension()).
 _depends_mysqlnd="$pkgname-openssl"
 _depends_pdo_mysql="$pkgname-pdo $pkgname-mysqlnd"
@@ -46,7 +46,7 @@ _depends_phar="$pkgname"
 # load index based on number of dependencies.
 _depends_mysqli="$pkgname-mysqlnd $pkgname-openssl"
 makedepends="
-       autoconf
+       $depends_dev
        apache2-dev
        aspell-dev
        bison
@@ -75,7 +75,6 @@ makedepends="
        libzip-dev
        net-snmp-dev
        openldap-dev
-       pcre2-dev
        postgresql-dev
        re2c
        recode-dev

[bratkartoffel]

outdated / merged with fda7e51

[andypost]

Sadly it was commited before 3.10 and will need a lot of rebuilding dependent packages