Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize history comparation #12967

Merged

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

1.optimize history comparation
2.support gray migrate executor times param

Brief changelog

XX

Verifying this change

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 56.04396% with 40 lines in your changes missing coverage. Please review.

Project coverage is 72.27%. Comparing base (d30bff0) to head (4895e94).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...ba/nacos/config/server/service/HistoryService.java 50.00% 19 Missing and 8 partials ⚠️
...s/config/server/model/ConfigHistoryInfoDetail.java 80.00% 6 Missing ⚠️
.../server/service/ConfigGrayModelMigrateService.java 0.00% 5 Missing ⚠️
...nfig/server/controller/v2/HistoryControllerV2.java 0.00% 1 Missing ⚠️
...gin/datasource/mapper/HistoryConfigInfoMapper.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12967      +/-   ##
=============================================
- Coverage      72.28%   72.27%   -0.01%     
+ Complexity     10005     9998       -7     
=============================================
  Files           1309     1309              
  Lines          41979    41991      +12     
  Branches        4411     4405       -6     
=============================================
+ Hits           30343    30350       +7     
- Misses          9515     9517       +2     
- Partials        2121     2124       +3     
Files with missing lines Coverage Δ
...os/config/server/controller/HistoryController.java 83.33% <ø> (-1.29%) ⬇️
...nfig/server/controller/v2/HistoryControllerV2.java 77.27% <0.00%> (-3.68%) ⬇️
...gin/datasource/mapper/HistoryConfigInfoMapper.java 56.00% <0.00%> (ø)
.../server/service/ConfigGrayModelMigrateService.java 0.00% <0.00%> (ø)
...s/config/server/model/ConfigHistoryInfoDetail.java 83.07% <80.00%> (ø)
...ba/nacos/config/server/service/HistoryService.java 55.95% <50.00%> (-3.14%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30bff0...4895e94. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Dec 18, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion merged commit 0556181 into alibaba:develop Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants