Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): endpoint level timeout part 2 [skip-bc] #4318

Merged
merged 22 commits into from
Jan 13, 2025

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jan 8, 2025

🧭 What and Why

🎟 JIRA Ticket: DI-3322 & DI-3327 & DI-3328 & DI-3329 & DI-3330 & DI-3331 & DI-3332 & DI-3333 & DI-3382

Changes included:

  • Swift
  • Kotlin
  • Java
  • Scala
  • C#
  • PHP
  • Go
  • Dart?

🧪 Test

@Fluf22 Fluf22 self-assigned this Jan 8, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 8, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 4bacd79fa8f07a0415824677e0da4179bf0f0dad
🍃 Generated commit 2a8a904d6f54238b0ac448710b7fc1fa0f91d1d0
🌲 Generated branch generated/fix/endpoint-level-timeouts
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1633
javascript 1584
php 1476
csharp 1433
python 1096
java 1095
ruby 814
swift 755

@Fluf22 Fluf22 force-pushed the fix/endpoint-level-timeouts branch 10 times, most recently from 9e7e6a9 to e53bc13 Compare January 10, 2025 10:00
@Fluf22
Copy link
Contributor Author

Fluf22 commented Jan 10, 2025

After the next release, I will rebase this PR on main so the CI for Java 17 can pass

@Fluf22 Fluf22 marked this pull request as ready for review January 10, 2025 10:13
@Fluf22 Fluf22 requested a review from a team as a code owner January 10, 2025 10:13
@millotp
Copy link
Collaborator

millotp commented Jan 10, 2025

After the next release, I will rebase this PR on main so the CI for Java 17 can pass

Or you can add [skip-bc] at the end of the title

@Fluf22
Copy link
Contributor Author

Fluf22 commented Jan 10, 2025

Or you can add [skip-bc] at the end of the title

Yeah but it's not an urgent PR? I don't think it will be merged before next week, so let's wait?

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is huge !

@millotp millotp changed the title feat(clients): endpoint level timeout part 2 feat(clients): endpoint level timeout part 2 [skip-bc] Jan 10, 2025
@Fluf22 Fluf22 force-pushed the fix/endpoint-level-timeouts branch from e2db756 to d514a55 Compare January 13, 2025 10:11
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg !

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

respectable

@Fluf22 Fluf22 merged commit 57d528a into main Jan 13, 2025
28 checks passed
@Fluf22 Fluf22 deleted the fix/endpoint-level-timeouts branch January 13, 2025 10:42
algolia-bot added a commit that referenced this pull request Jan 13, 2025
…ated) [skip ci]

Co-authored-by: Thomas Raffray <[email protected]>
Co-authored-by: Pierre Millot <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 13, 2025
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jan 13, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 13, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jan 13, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jan 13, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 13, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 13, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jan 13, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants