Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rustls 0.22 #690

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Update to rustls 0.22 #690

merged 1 commit into from
Dec 4, 2023

Conversation

jsha
Copy link
Collaborator

@jsha jsha commented Dec 1, 2023

DO NOT MERGE until rustls 0.22 is actually released. Right now this uses a Cargo.toml patch to get the latest version before it's released.

Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@jsha jsha force-pushed the update-rustls-0.22 branch 2 times, most recently from 3fc1656 to efc2f33 Compare December 2, 2023 18:57
Cargo.toml Outdated
@@ -44,8 +44,9 @@ encoding_rs = { version = "0.8", optional = true }
cookie_store = { version = "0.20", optional = true, default-features = false, features = ["preserve_order"] }
log = "0.4"
webpki = { package = "rustls-webpki", version = "0.101", optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider also update rustls-webpki to 0.102?

@jsha jsha force-pushed the update-rustls-0.22 branch 2 times, most recently from 22ae189 to a111326 Compare December 3, 2023 16:57
@Revertron
Copy link

rustls 0.22 has been released!
Can we update ureq? :)
(I need the MIPS support added by rustls)

@jsha jsha force-pushed the update-rustls-0.22 branch from a111326 to 09142b7 Compare December 4, 2023 18:19
@algesten
Copy link
Owner

algesten commented Dec 4, 2023

@jsha once it's failing on httpbin calls, you need to keep rerun only the failed tests many times to "grind" it through.

@jsha jsha merged commit 53c59aa into algesten:main Dec 4, 2023
47 checks passed
@jsha jsha deleted the update-rustls-0.22 branch December 4, 2023 22:41
@amunra
Copy link

amunra commented Dec 7, 2023

Hello, I'm also upgrading my crate to 0.22 and using this PR as inspiration.

Here I've noticed supported_verify_schemes was left as todo!().
Is that intentional? I'm really scratching my head on what that method should return.

@cpu
Copy link
Contributor

cpu commented Dec 7, 2023

I'm really scratching my head on what that method should return.

@amunra If you want your ServerCertVerifier to act as it did prior to Rustls 0.22 when there was a default impl of supported_verify_schemes you can change the body to defer to the ring based provider's supported verify schemes:

fn supported_verify_schemes(&self) -> Vec<rustls::SignatureScheme> {
    rustls::crypto::ring::default_provider()
        .signature_verification_algorithms
        .supported_schemes()
}

@emilk
Copy link
Contributor

emilk commented Jan 10, 2024

I would appreciate a patch release with this 🙏

@aeyoll
Copy link

aeyoll commented Jan 30, 2024

hello @algesten, can you create a new release with this fix please? Thanks a lot!

@algesten
Copy link
Owner

Alright. Let's do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants