-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to rustls 0.22 #690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
3fc1656
to
efc2f33
Compare
Cargo.toml
Outdated
@@ -44,8 +44,9 @@ encoding_rs = { version = "0.8", optional = true } | |||
cookie_store = { version = "0.20", optional = true, default-features = false, features = ["preserve_order"] } | |||
log = "0.4" | |||
webpki = { package = "rustls-webpki", version = "0.101", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider also update rustls-webpki
to 0.102?
22ae189
to
a111326
Compare
|
a111326
to
09142b7
Compare
@jsha once it's failing on httpbin calls, you need to keep rerun only the failed tests many times to "grind" it through. |
Hello, I'm also upgrading my crate to 0.22 and using this PR as inspiration. Here I've noticed |
@amunra If you want your fn supported_verify_schemes(&self) -> Vec<rustls::SignatureScheme> {
rustls::crypto::ring::default_provider()
.signature_verification_algorithms
.supported_schemes()
} |
I would appreciate a patch release with this 🙏 |
hello @algesten, can you create a new release with this fix please? Thanks a lot! |
Alright. Let's do it. |
DO NOT MERGE until rustls 0.22 is actually released. Right now this uses a Cargo.toml patch to get the latest version before it's released.