Pull Request: C2_Rana_Statistics #579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fadel1493 can you please review me ?!! |
| # [average number of trials - Story 2.3] | ||
| # Select a problem_id and count the number of students who tried to answer this problem | ||
| # Parameters : | ||
| # success_attempts:an intger value that shows the number of correct answers by students |
There was a problem hiding this comment.
@ranaelnagar please only use tabs, not space and tab
|
@Rania-Abdel-Fattah please add labels :) |
|
@AhmedOsam you mean @ranaelnagar not me :D |
| render "show_statistics" | ||
| end | ||
| end |
There was a problem hiding this comment.
leave an empty line before "end" of the whole class
|
@ranaelnagar code reopen |
|
|
||
| # [number_of_problems_answered_correctly - Story 2.1] |
There was a problem hiding this comment.
@ranaelnagar "Number Of Problems Answered Correctly"
|
@ranaelnagar Doc. reopen. |
| if Solution.where(problem_id: @problem.id) != 0 | ||
| @attempt=Solution.where(problem_id: @problem.id).pluck(:code) | ||
| if @attempt == "" | ||
| flash[:notice]="no one answered this problem" |
There was a problem hiding this comment.
@ranaelnagar add space before and after '='
|
@ranaelnagar Code reopen. |
|
@ranaelnagar Code verified. |
|
@rami-khalil please Can you review again ?!! 🐰 |
…nto C2_Rana_statistics Conflicts: tutor/Gemfile tutor/app/controllers/problems_controller.rb tutor/app/views/tracks/show.html.erb
…nto C2_Rana_statistics
|
@rami-khalil Review .... 😢 |
|
@ranaelnagar please resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ahmedhagii @AhmedElassuty @AhmedOsam @Mamdou7 @metawaa please review
Issue #346