Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request: C1_Akram_491_solve_contest_problem_5.20 #552

Closed
wants to merge 37 commits into from

Conversation

ahmedhagii
Copy link
Collaborator

Issue #491

Please Review Code: @MohabGhanim
Please Review Tests: @KhaledHelmy
Please Review Docs: @mohamedsaeed93

@ahmedhagii ahmedhagii added this to the Sprint 2 milestone May 16, 2014
@ahmedhagii ahmedhagii self-assigned this May 16, 2014
@KhaledHelmy
Copy link
Collaborator

@ahmedhagii After the contest ends, you shouldn't accept any submissions to a contest problem and @MohabGhanim shouldn't update the standings accordingly. Please, fix the conflicts as well :)

@ahmedhagii
Copy link
Collaborator Author

@KhaledHelmy he just submits and gets the reply without any linking to the DB, I'm just supporting the fact that some user maybe interested in solving a contest problem after it ends. Because we have a separate table for the contest problems so the only way to try one of theses problems is through a contest

@KhaledHelmy
Copy link
Collaborator

@ahmedhagii and that should be the case :) .. He shouldn't be able to try a contest problem except in a contest ;) .. Anyways, what is your scenario if a student submits a contest problem after the contest ends as I guess I didn't get it from your last comment?

@ahmedhagii
Copy link
Collaborator Author

@KhaledHelmy the table where standings get the stats from is not updated when the contest is over so there will be no change in the standings :)

@ahmedhagii
Copy link
Collaborator Author

@KhaledHelmy I just replies to him with accepted, comp err ... without any updates in the tables

@ahmedhagii
Copy link
Collaborator Author

@KhaledHelmy in any site supporting programming contests, I can solve problems after the contest ends i.e. Code Jam :D

@KhaledHelmy
Copy link
Collaborator

@ahmedhagii Ok, great. Then @MohabGhanim, you should consider not to update the standings table in this case.

@KhaledHelmy
Copy link
Collaborator

@ahmedhagii Why is this closed?

@ahmedhagii
Copy link
Collaborator Author

@KhaledHelmy i'll wait for some pull requests to be merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants