-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request: C1_Akram_491_solve_contest_problem_5.20 #552
Conversation
…ition to documentation
@ahmedhagii After the contest ends, you shouldn't accept any submissions to a contest problem and @MohabGhanim shouldn't update the standings accordingly. Please, fix the conflicts as well :) |
@KhaledHelmy he just submits and gets the reply without any linking to the DB, I'm just supporting the fact that some user maybe interested in solving a contest problem after it ends. Because we have a separate table for the contest problems so the only way to try one of theses problems is through a contest |
@ahmedhagii and that should be the case :) .. He shouldn't be able to try a contest problem except in a contest ;) .. Anyways, what is your scenario if a student submits a contest problem after the contest ends as I guess I didn't get it from your last comment? |
@KhaledHelmy the table where standings get the stats from is not updated when the contest is over so there will be no change in the standings :) |
@KhaledHelmy I just replies to him with accepted, comp err ... without any updates in the tables |
@KhaledHelmy in any site supporting programming contests, I can solve problems after the contest ends i.e. Code Jam :D |
@ahmedhagii Ok, great. Then @MohabGhanim, you should consider not to update the standings table in this case. |
@ahmedhagii Why is this closed? |
@KhaledHelmy i'll wait for some pull requests to be merged first |
Issue #491
Please Review Code: @MohabGhanim
Please Review Tests: @KhaledHelmy
Please Review Docs: @mohamedsaeed93