Pull Request: C3_Fadel_211_remove_helping_hints_4.21 #338
Conversation
| <th style = "width:20%">Delete</th> | ||
|
|
||
| <td><%= button_to "Delete", {controller: :hints, action: :destroy, id: hint1.id}, | ||
| :method => :delete, class: 'btn btn-primary btn-xs' %></td> |
There was a problem hiding this comment.
@fadel1493 please fix indentation in this line
|
@fadel1493 code reopen |
| # [Delete a Hint - Story 4.21] | ||
| # This action takes the hint id, removes it from the database | ||
| # and then redirects the user to the edit page accompanied | ||
| # with a "Hint deleted" message. |
There was a problem hiding this comment.
@fadel1Add a tab in line 7 and 8 instead of a space. It should be like this:
# This action takes the hint id, removes it from the database
# and then redirects the user to the edit page accompanied
# with a "Hint deleted" message.
|
@fadel1493 Please check the previous comments. Doc. reopen. |
|
@fadel1493 Doc. verified. |
| flash[:success_deletion] = "Hint deleted." | ||
| redirect_to :controller => 'model_answers', :action => 'edit', :id => @@answer_id | ||
| end | ||
| end |
There was a problem hiding this comment.
@fadel1493 leave and empty line before last end
|
@Ahmed-Atef @Mamdou7 Please review. |
|
@Rania-Abdel-Fattah @ranaelnagar Please scenario review |
|
@fadel1493 code verified , fix conflicts with master |
mohamedfadel
changed the title
|
@KhaledHelmy Please review code, and Atef verified above. |
|
@fadel1493 Ok, but please fix the conflicts with the master first in order to review the new code directly :) |
|
@KhaledHelmy Fixed. Please review |
|
Fixed @Ahmed-Atef |
|
@Ahmed-Atef Please verify if complete |
|
@Ahmed-Atef Please review |
|
@fadel1493 resolve conflicts |
|
@rami-khalil conflicts resolved |
|
@fadel1493 resolve conflicts.. |
|
@rami-khalil conflicts resolved |
| @@ -52,4 +57,5 @@ | |||
| </tbody> | |||
| </table> | |||
| <% end %> | |||
| </div> | |||
| </div> | |||
|
|
|||
|
@fadel1493 please check comments above |
| <th style = "width:20%">Delete</th> | ||
| <td><%= button_to "Delete", | ||
| {controller: :hints, action: :destroy, id: hint1.id}, | ||
| :method => :delete, class: 'btn btn-primary btn-xs' %></td> |
There was a problem hiding this comment.
@fadel1493 line too long
|
@Ahmed-Atef code pending |
|
@fadel1493 i hate to be that guy but u forgot about the extra line at the end |
|
@Ahmed-Atef which line? |
|
@fadel1493 line 62 is extra in the mode_answer/_index |
|
@Ahmed-Atef done |
|
@fadel1493 Code verified tag scenario reviewers |
|
@fadel1493 i got this error |
|
@fadel1493 what is hint1? |
|
@fadel1493 u r passing the id for your action destroy as hint1.id |
|
@fadel1493 are you sure that your button should be here ? as there are related to the model answer |
Issue #211
Fixed previous issues and removed Nadine's part
Please review:
@Rania-Abdel-Fattah @Ahmed-Moataz @Ahmed-Atef @ahmed93 @ranaelnagar