Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request: C5_Serag_206_Profile_5.8 #321

Merged
merged 24 commits into from
Apr 24, 2014
Merged

Conversation

Serag8
Copy link
Collaborator

@Serag8 Serag8 commented Apr 22, 2014

@MussabElDash
Copy link
Collaborator

@Serag8 Docs Verified

@husseny
Copy link
Collaborator

husseny commented Apr 22, 2014

rename this pull request and follow the convention @Serag8

@husseny
Copy link
Collaborator

husseny commented Apr 22, 2014

Pull Request: [Branch_name]

@Serag8 Serag8 changed the title Pull Request C5 - Profile - Story 5.8 Pull Request: C5 Serag 206 Profile 5.8 Apr 22, 2014
@Serag8
Copy link
Collaborator Author

Serag8 commented Apr 22, 2014

@husseny Renamed, I was following this Pull Request #320

}
.tab.active {
display:block;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the aim of the documentation in this file? @Serag8
is it auto generated?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question for students.css, teaching assistants.css @Serag8

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Serag8
Copy link
Collaborator Author

Serag8 commented Apr 24, 2014

@rami-khalil
apologies for any inconvenience,
Kindly review

<th>Options</th>
<th></th>
</tr>
<% @courses.each do |c| %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serag8 c is not descriptive.

@hashcashier
Copy link
Contributor

@Serag8 code reopen

@Serag8
Copy link
Collaborator Author

Serag8 commented Apr 24, 2014

@rami-khalil @husseny
code pending, Kindly review

},
class: "btn btn-success",
method: :get,
style: "text-decoration:none" %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation of the past 3 lines @Serag8
one tab back

@Serag8
Copy link
Collaborator Author

Serag8 commented Apr 24, 2014

Fixed @husseny

@hashcashier
Copy link
Contributor

@Serag8 Code verified.

@Serag8
Copy link
Collaborator Author

Serag8 commented Apr 24, 2014

@husseny Please merge

@husseny
Copy link
Collaborator

husseny commented Apr 24, 2014

@Serag8 code verified

husseny added a commit that referenced this pull request Apr 24, 2014
@husseny husseny merged commit dd06856 into master Apr 24, 2014
@MussabElDash MussabElDash deleted the C5_Serag_206_Profile_5.8 branch June 17, 2014 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants