-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request: C5_Serag_206_Profile_5.8 #321
Conversation
…nto C5_Serag_206_Profile_5.8
@Serag8 Docs Verified |
rename this pull request and follow the convention @Serag8 |
Pull Request: [Branch_name] |
} | ||
.tab.active { | ||
display:block; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the aim of the documentation in this file? @Serag8
is it auto generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question for students.css, teaching assistants.css @Serag8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
…ed empty index actions & removed extra spaces
@rami-khalil |
<th>Options</th> | ||
<th></th> | ||
</tr> | ||
<% @courses.each do |c| %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Serag8 c is not descriptive.
@Serag8 code reopen |
@rami-khalil @husseny |
}, | ||
class: "btn btn-success", | ||
method: :get, | ||
style: "text-decoration:none" %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix indentation of the past 3 lines @Serag8
one tab back
Fixed @husseny |
@Serag8 Code verified. |
@husseny Please merge |
@Serag8 code verified |
Pull Request: C5_Serag_206_Profile_5.8
Issue #206 Reviewers: @husseny @MussabElDash @nadineadel @LinSara