-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3 fadel 211 remove helping hints 4.21 #307
Conversation
…om/alaashafaee/Coolsoft-14 into C3_Fadel_210_adding_helping_hints_4.12
@fadel1493 u cannot merge branch that is not hrs in your branch |
# @hints: All the previous hints that had been entered before. | ||
# @hints_check: All the previous hints that had been entered before to check if it is a hint or a tip. | ||
# Return : table with all previous hints | ||
# Author: Nadine Adel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fadel1493 You can't make a pull request of other peoples' methods. Apply this to the rest of the file.
@fadel1493 Please see the previous comments. Doc. reopen. |
# category: states whether it is a hint or tip | ||
# Returns: | ||
# Redirects to edit page on success, refreshes on failure | ||
# Author: Mohamed Fadel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# [Adding Helping Hints - 4.12]
# Creates a new record to Hint Table
# Parameters:
# owner_id: ID of the hint owner
# owner type: type of hint owner
# category: states whether it is a hint or tip
# Returns:
# Redirects to edit page on success, refreshes on failure
# Author: Mohamed Fadel
@fadel1493 It should be like that. Please apply this to the rest of the file.
@fadel1493 Please check the previous comments. Doc. reopen. |
remove Nadine's code first |
|
||
@@answer_id = nil | ||
|
||
#[Adding Helping Hints - 4.12] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fadel1493 Please add a space after the hash when there is no tab.
@fadel1493 Please check the previous comments. Doc. reopen. |
@fadel1493 Please remove Nadine's code from your branch. |
@fadel1493 Unmergeable code cannot be reviewed. Please update with the master and fix the conflicts. |
Issue #211
Please review:
@Rania-Abdel-Fattah @ahmed93 @ranaelnagar @Ahmed-Moataz @Ahmed-Atef