Issue #206 fixed descriptivity and indentation

alaashafaee · Apr 24, 2014 · c369f25 · c369f25
1 parent 0f22b6d
commit c369f25
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 26 deletions.
diff --git a/tutor/app/assets/javascripts/lecturers.js b/tutor/app/assets/javascripts/lecturers.js
@@ -1,5 +1,5 @@
 $(document).ready(function() {
-	$('.tabs .tab-links a').on('click', function(e) {
+	$('.tabs .tab-links a').on('click', function(element) {
 		var currentAttrValue = $(this).attr('href');
 		// Show/Hide Tabs
 		$('.tabs ' + currentAttrValue).siblings().slideUp(400);
@@ -8,6 +8,6 @@ $(document).ready(function() {
 		//$('.tabs ' + currentAttrValue).fadeIn(400).siblings().hide();
 		// Change/remove current tab to active
 		$(this).parent('li').addClass('active').siblings().removeClass('active');
-		e.preventDefault();
+		element.preventDefault();
 	});
 });
diff --git a/tutor/app/assets/javascripts/students.js b/tutor/app/assets/javascripts/students.js
@@ -1,5 +1,5 @@
 $(document).ready(function() {
-	$('.tabs .tab-links a').on('click', function(e) {
+	$('.tabs .tab-links a').on('click', function(element) {
 		var currentAttrValue = $(this).attr('href');
 		// Show/Hide Tabs
 		$('.tabs ' + currentAttrValue).siblings().slideUp(400);
@@ -8,6 +8,6 @@ $(document).ready(function() {
 		//$('.tabs ' + currentAttrValue).fadeIn(400).siblings().hide();
 		// Change/remove current tab to active
 		$(this).parent('li').addClass('active').siblings().removeClass('active');
-		e.preventDefault();
+		element.preventDefault();
 	});
 });
diff --git a/tutor/app/assets/javascripts/teaching_assistants.js b/tutor/app/assets/javascripts/teaching_assistants.js
@@ -1,5 +1,5 @@
 $(document).ready(function() {
-	$('.tabs .tab-links a').on('click', function(e) {
+	$('.tabs .tab-links a').on('click', function(element) {
 		var currentAttrValue = $(this).attr('href');
 		// Show/Hide Tabs
 		$('.tabs ' + currentAttrValue).siblings().slideUp(400);
@@ -8,6 +8,6 @@ $(document).ready(function() {
 		//$('.tabs ' + currentAttrValue).fadeIn(400).siblings().hide();
 		// Change/remove current tab to active
 		$(this).parent('li').addClass('active').siblings().removeClass('active');
-		e.preventDefault();
+		element.preventDefault();
 	});
 });
diff --git a/tutor/app/views/lecturers/show.html.erb b/tutor/app/views/lecturers/show.html.erb
@@ -16,24 +16,24 @@
 					<th>Options</th>
 					<th></th>
 				</tr>
-				<% @courses.each do |c| %>
+				<% @courses.each do |course| %>
 					<tr>
 						<td>
-							<%= link_to c.name,
+							<%= link_to course.name,
 								:controller => 'courses',
 								:action => 'show',
-								:id => c.id, :method => :get,
+								:id => course.id, :method => :get,
 								class: "btn btn-success" %>
 						</td>
-						<td><%= c.code %></td>
+						<td><%= course.code %></td>
 						<% if current_lecturer %>
 							<td>
 								<%= link_to "Manage Course",
 									{
 										:controller => 'courses',
 										:action => 'edit',
 										:method => :get,
-										:id => c.id
+										:id => course.id
 									},
 									class: "btn btn-success",
 									style: "text-decoration:none" %>
@@ -44,8 +44,8 @@
 								{
 									:controller => 'discussion_boards',
 									:action => 'show',
-									:id => c.id
-									},
+									:id => course.id
+								},
 								class: "btn btn-success",
 								method: :get,
 								style: "text-decoration:none" %>

diff --git a/tutor/app/views/students/show.html.erb b/tutor/app/views/students/show.html.erb
@@ -17,25 +17,25 @@
 					<th>Options</th>
 					<th></th>
 				</tr>
-				<% @courses.each do |c| %>
+				<% @courses.each do |course| %>
 					<tr>
 						<td>
-							<%= link_to c.name,
+							<%= link_to course.name,
 								:controller => 'courses',
 								:action => 'show',
-								:id => c.id,
+								:id => course.id,
 								:method => :get,
 								class: "btn btn-success" %>
 						</td>
-						<td><%= c.code %></td>
+						<td><%= course.code %></td>
 						<% if current_lecturer %>
 							<td>
 								<%= link_to "Manage Course",
 									{
 										:controller => 'courses',
 										:action => 'edit',
 										:method => :get,
-										:id => c.id
+										:id => course.id
 									},
 									class: "btn btn-success",
 									style: "text-decoration:none" %>
@@ -46,8 +46,8 @@
 								{
 									:controller => 'discussion_boards',
 									:action => 'show',
-									:id => c.id
-									},
+									:id => course.id
+								},
 									class: "btn btn-success",
 									method: :get,
 									style: "text-decoration:none" %>

diff --git a/tutor/app/views/teaching_assistants/show.html.erb b/tutor/app/views/teaching_assistants/show.html.erb
@@ -16,23 +16,24 @@
 					<th>Options</th>
 					<th></th>
 				</tr>
-				<% @courses.each do |c| %>
+				<% @courses.each do |course| %>
 					<tr>
 						<td>
-							<%= link_to c.name,
+							<%= link_to course.name,
 							:controller => 'courses',
-							:action => 'show', :id => c.id,
+							:action => 'show', :id => course.id,
 							:method => :get,
 							class: "btn btn-success" %>
 						</td>
-						<td><%= c.code %></td>
+						<td><%= course.code %></td>
 						<% if current_lecturer %>
 							<td>
 								<%= link_to "Manage Course",
 									{
 										:controller => 'courses',
 										:action => 'edit',
-										:method => :get, :id => c.id
+										:method => :get,
+										:id => course.id
 									},
 									class: "btn btn-success",
 									style: "text-decoration:none" %>
@@ -42,7 +43,8 @@
 							<%= link_to "Discussion Board",
 								{
 									:controller => 'discussion_boards',
-									:action => 'show', :id => c.id
+									:action => 'show',
+									:id => course.id
 								},
 								class: "btn btn-success",
 								method: :get,