Skip to content

Commit

Permalink
Issue #206 fixed % spaces & reordered tabs
Browse files Browse the repository at this point in the history
  • Loading branch information
serag committed Apr 23, 2014
1 parent 56ce865 commit a1c4841
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 36 deletions.
24 changes: 12 additions & 12 deletions tutor/app/views/lecturers/show.html.erb
Original file line number Diff line number Diff line change
@@ -1,25 +1,18 @@
<!DOCTYPE html>
<html>
<head>
<title>CoolSoft - Java tutor | <%= @lecturer.id%>'s Profile</title>
<title>CoolSoft - Java tutor | <%= @lecturer.id %>'s Profile</title>
</head>
<body>
<h1> <%= image_tag(@lecturer.profile_image_url.to_s) if @lecturer.profile_image? %> <%= @lecturer.name%>'s Profile </h1>
<h1> <%= image_tag(@lecturer.profile_image_url.to_s) if @lecturer.profile_image? %> <%= @lecturer.name %>'s Profile </h1>
<div class="tabs">
<ul class="tab-links">
<li class="active"><a href="#tab1">Info</a></li>
<li><a href="#tab2">Statistics</a></li>
<li><a href="#tab3">Course</a></li>
<li class="active"><a href="#tab1">Course</a></li>
<li><a href="#tab2">Info</a></li>
<li><a href="#tab3">Statistics</a></li>
</ul>
<div class="tab-content">
<div id="tab1" class="tab active">
<p> <b>Name:</b> <%= @lecturer.name%> </p>
<p> <b>Email:</b> <%= @lecturer.email%> </p>
</div>
<div id="tab2" class="tab">
<p> @lecturer.getStat() "to be reviewed" </p>
</div>
<div id="tab3" class="tab">
<table class = "table table-striped", style = "width:80%">
<tr>
<th>Name</th>
Expand All @@ -44,6 +37,13 @@
<% end %>
</table>
</div>
<div id="tab2" class="tab">
<p> <b>Name:</b> <%= @lecturer.name %> </p>
<p> <b>Email:</b> <%= @lecturer.email %> </p>
</div>
<div id="tab3" class="tab">
<p> @lecturer.getStat() "to be reviewed" </p>
</div>
</div>
</div>
</body>
Expand Down
24 changes: 12 additions & 12 deletions tutor/app/views/students/show.html.erb
Original file line number Diff line number Diff line change
@@ -1,25 +1,18 @@
<!DOCTYPE html>
<html>
<head>
<title>CoolSoft - Java tutor | <%= @student.id%>'s Profile</title>
<title>CoolSoft - Java tutor | <%= @student.id %>'s Profile</title>
</head>
<body>
<h1> <%= image_tag(@student.profile_image_url.to_s) if @student.profile_image? %> <%= @student.name%>'s Profile </h1>
<h1> <%= image_tag(@student.profile_image_url.to_s) if @student.profile_image? %> <%= @student.name %>'s Profile </h1>
<div class="tabs">
<ul class="tab-links">
<li class="active"><a href="#tab1">Info</a></li>
<li><a href="#tab2">Statistics</a></li>
<li><a href="#tab3">Course</a></li>
<li class="active"><a href="#tab1">Course</a></li>
<li><a href="#tab2">Info</a></li>
<li><a href="#tab3">Statistics</a></li>
</ul>
<div class="tab-content">
<div id="tab1" class="tab active">
<p> <b>Name:</b> <%= @student.name%> </p>
<p> <b>Email:</b> <%= @student.email%> </p>
</div>
<div id="tab2" class="tab">
<p> @student.getStat() "to be reviewed" </p>
</div>
<div id="tab3" class="tab">
<table class = "table table-striped", style = "width:80%">
<tr>
<th>Name</th>
Expand All @@ -44,6 +37,13 @@
<% end %>
</table>
</div>
<div id="tab2" class="tab">
<p> <b>Name:</b> <%= @student.name %> </p>
<p> <b>Email:</b> <%= @student.email %> </p>
</div>
<div id="tab3" class="tab">
<p> @student.getStat() "to be reviewed" </p>
</div>
</div>
</div>
</body>
Expand Down
24 changes: 12 additions & 12 deletions tutor/app/views/teaching_assistants/show.html.erb
Original file line number Diff line number Diff line change
@@ -1,25 +1,18 @@
<!DOCTYPE html>
<html>
<head>
<title>CoolSoft - Java tutor | <%= @teaching_assistant.id%>'s Profile</title>
<title>CoolSoft - Java tutor | <%= @teaching_assistant.id %>'s Profile</title>
</head>
<body>
<h1> <%= image_tag(@teaching_assistant.profile_image_url.to_s) if @teaching_assistant.profile_image? %> <%= @teaching_assistant.name%>'s Profile </h1>
<h1> <%= image_tag(@teaching_assistant.profile_image_url.to_s) if @teaching_assistant.profile_image? %> <%= @teaching_assistant.name %>'s Profile </h1>
<div class="tabs">
<ul class="tab-links">
<li class="active"><a href="#tab1">Info</a></li>
<li><a href="#tab2">Statistics</a></li>
<li><a href="#tab3">Course</a></li>
<li class="active"><a href="#tab1">Course</a></li>
<li><a href="#tab2">Info</a></li>
<li><a href="#tab3">Statistics</a></li>
</ul>
<div class="tab-content">
<div id="tab1" class="tab active">
<p> <b>Name:</b> <%= @teaching_assistant.name%> </p>
<p> <b>Email:</b> <%= @teaching_assistant.email%> </p>
</div>
<div id="tab2" class="tab">
<p> @teaching_assistant.getStat() "to be reviewed" </p>
</div>
<div id="tab3" class="tab">
<table class = "table table-striped", style = "width:80%">
<tr>
<th>Name</th>
Expand All @@ -44,6 +37,13 @@
<% end %>
</table>
</div>
<div id="tab2" class="tab">
<p> <b>Name:</b> <%= @teaching_assistant.name %> </p>
<p> <b>Email:</b> <%= @teaching_assistant.email %> </p>
</div>
<div id="tab3" class="tab">
<p> @teaching_assistant.getStat() "to be reviewed" </p>
</div>
</div>
</div>
</body>
Expand Down

1 comment on commit a1c4841

@Serag8
Copy link
Collaborator

@Serag8 Serag8 commented on a1c4841 Apr 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@husseny Kindly review but do not merge yet.

Please sign in to comment.