Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pass at watch filtering #873

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Quantumplation
Copy link
Contributor

This allows you to type and hit enter while running check --watch, which will update the -m setting, basically.

This can be super useful for filtering down to just one test to run and iterate on, before pressing enter again to clear it out and go back to running everything again.

I'm sure this deserves some cleanup, but I wanted to get this out there for feedback.

Related to a discussion I started here: #865

This allows you to type and hit enter while running check --watch,
which will update the -m setting, basically.

This can be super useful for filtering down to just one test to run and
iterate on, before pressing enter again to clear it out and go back to
running everything again.
@Quantumplation Quantumplation requested a review from a team as a code owner March 10, 2024 17:32
@rvcas
Copy link
Member

rvcas commented Mar 18, 2024

I'm actually wondering if there's a case for reworking watch to be a full blown tui kind of thing using ratatui. Remove watch flag from check and docs and then make a new command called aiken watch or aiken dev. It immediately displays all the tests like check, shows a nice input to filter them, a command to rerun manually, toggle whether or not docs should be rebuilt along with rerunning tests. I see what you're trying to do with termion and I recall you mentioning being unhappy with how things displayed with it. Perhaps just using ratatui would make things simpler?

@Quantumplation
Copy link
Contributor Author

Yea, that sounds awesome; I'd be happy to do that instead, just wasn't sure if you wanted me to be poking that much into things 😅

@KtorZ
Copy link
Member

KtorZ commented Mar 21, 2024

reworking watch to be a full blown tui kind of thing

aiken ide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🫡 In Progress
Development

Successfully merging this pull request may close these issues.

3 participants