Added Benchmarking; Added Sampler to Prelude for Benchmarking #1071
Conversation
|
After having these two types unified as A lot of users won't be exposed to this, as they will simply use the pre-defined Fuzzers in the Fuzz library, but for users crafting their own Fuzzers, do we want to introduce breaking changes? |
Riley-Kilgore
force-pushed
the
benchmarking-wip
branch
from
3efd57a to
70daa4e
Compare
| @@ -182,6 +183,7 @@ impl fmt::Display for Token { | |||
| Token::Once => "once", | |||
| Token::Validator => "validator", | |||
| Token::Via => "via", | |||
| Token::Benchmark => "benchmark", | |||
There was a problem hiding this comment.
Let's call it bench; not so much because it's shorter but because it's quite often used in benchmarking terminology (bench refer to the individual tests of a benchmark, which aggregates all benches).
| pub name: String, | ||
| pub on_test_failure: OnTestFailure, | ||
| pub program: Program<Name>, | ||
| pub fuzzer: Fuzzer<Name>, |
There was a problem hiding this comment.
That last one is suspicious? It ought not to be a Fuzzer here I believe.
| pub enum Prng { | ||
| Seeded { choices: Vec<u8>, uplc: PlutusData }, | ||
| Replayed { choices: Vec<u8>, uplc: PlutusData }, | ||
| Seeded { | ||
| choices: Vec<u8>, | ||
| uplc: PlutusData, | ||
| iteration: usize, | ||
| }, | ||
| Replayed { | ||
| choices: Vec<u8>, | ||
| uplc: PlutusData, | ||
| iteration: usize, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Why is changing the PRNG necessary? I don't think that it is right? The size parameter should be holistic for an entire PRNG and influence all random choices down the line.
That'll certainly require quite a lot of change in the Fuzz library, which I think we can avoid by making the context be provided as a closure instead of passed as an extra parameter. So, fundamentally, have: instead of |
Riley-Kilgore
changed the title
No description provided.