-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uv lockfile in readthedocs build #6685
base: main
Are you sure you want to change the base?
Conversation
f22bf59
to
83a4406
Compare
c5da6fd
to
f39bf1f
Compare
Huh, 20 tests failed on my, such as
https://github.com/danielhollas/aiida-core/actions/runs/12694592672/job/35384697895 Is this a know failure? Weirdly, the tests pass on this PR. |
1786bf4
to
677dc31
Compare
The failing test is due to the timeout issue. |
+ update uv version
It seems not relate to timeout, and it only failed on your forked CI? BTW, the changes looks good, thanks for the work. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6685 +/- ##
=======================================
Coverage 77.99% 77.99%
=======================================
Files 563 563
Lines 41761 41761
=======================================
Hits 32567 32567
Misses 9194 9194 ☔ View full report in Codecov by Sentry. |
Now that we have a bit of good experience with uv lockfile, it would be nice to use it in more places to make various CI jobs more stable. Here I am using it for the RTD docs build. We've already been using uv there so that change is relatively straightforward.
Coincidentaly, ReadTheDocs made some updates to make the configuration with uv nicer, just a couple of days ago see readthedocs/readthedocs.org#11289 (comment) for details.
This also updates the uv version in RTD config.