Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update uv.lock + CI tweaks #6676

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

danielhollas
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (02cbe0c) to head (c054b5c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6676   +/-   ##
=======================================
  Coverage   77.94%   77.94%           
=======================================
  Files         563      563           
  Lines       41761    41761           
=======================================
  Hits        32545    32545           
  Misses       9216     9216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas
Copy link
Collaborator Author

There's one failing test in test-install with Python 3.9, due to astral-sh/setup-uv#219

        # In Cygwin paths like "c:\..." and '\cygdrive\c\...' are possible
>       if p_venv.parts[1] == "cygdrive":
E       IndexError: tuple index out of range

.venv/lib/python3.9/site-packages/IPython/core/interactiveshell.py:890: IndexError
========================================================== slowest 50 durations ===========================================================

(3 durations < 1s hidden.  Use -vv to show these durations.)
========================================================= short test summary info =========================================================
FAILED tests/tools/ipython/test_ipython_magics.py::test_ipython_magics - IndexError: tuple index out of range

@@ -64,8 +64,7 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Setup environment
# Note: The virtual environment in .venv was created by uv in previous step
run: source .venv/bin/activate && .github/workflows/setup.sh
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated setup-uv action now activates the virtual environment automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant