Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pytest timeout to 60s for every test #6674

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 20, 2024

not a single test should longer than 30s, if it happens something hang up, go and fix it.

@unkcpz unkcpz requested a review from agoscinski as a code owner December 20, 2024 15:20
not a single test should longer than 30s, if it happens something hang
up, go and fix it.
@unkcpz unkcpz requested a review from GeigerJ2 December 20, 2024 15:20
@unkcpz
Copy link
Member Author

unkcpz commented Dec 20, 2024

This change reveal some very slow tests which we may want to improve the test case or tag them with "slow" mark and run separately.

@agoscinski
Copy link
Contributor

As far as I see that is only the test_high_level_workflow_links. The construct_complex_graph, the reset and exporting and importing takes some time. All related to database interaction. Not sure if there is much room for improvement and if it is worth to think about.

@agoscinski
Copy link
Contributor

Maybe we can just put the timeout to 60s to have a large gap. If the tests just fail because the CI is a bit slower on that particular day, this becomes more annoying than useful. That should also cover the test_high_level_workflow_links test

@unkcpz unkcpz marked this pull request as ready for review January 8, 2025 15:49
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (1093026) to head (9bab75d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6674   +/-   ##
=======================================
  Coverage   77.94%   77.94%           
=======================================
  Files         563      563           
  Lines       41761    41761           
=======================================
  Hits        32545    32545           
  Misses       9216     9216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz changed the title Set pytest timeout to 30s for every test Set pytest timeout to 60s for every test Jan 8, 2025
@unkcpz unkcpz merged commit 17ab395 into aiidateam:main Jan 8, 2025
22 checks passed
@unkcpz unkcpz deleted the pytest-timeout- branch January 8, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants