Skip to content

Commit

Permalink
CI: Add matrix testing for both SQLite and PostgreSQL database backends
Browse files Browse the repository at this point in the history
Updates the GitHub Actions CI workflows ci-code.yml to include testing for both SQLite
and PostgreSQL database backends.
This will also increase the testing coverage over SQLite specific codebase.
  • Loading branch information
rabbull authored and unkcpz committed Jan 9, 2025
1 parent 8ae66fb commit a3ccec9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/ci-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.9', '3.12']
database-backend: [psql]
include:
- python-version: '3.9'
database-backend: sqlite

services:
postgres:
Expand Down Expand Up @@ -79,7 +83,7 @@ jobs:
run: |
${{ matrix.python-version == '3.9' && 'unset CI' || '' }}
${{ matrix.python-version == '3.9' && 'VIRTUAL_ENV=$PWD/.venv' || '' }}
pytest -n auto --db-backend psql -m 'not nightly' tests/ ${{ matrix.python-version == '3.9' && '--cov aiida' || '' }}
pytest -n auto --db-backend ${{ matrix.database-backend }} -m 'not nightly' tests/ ${{ matrix.python-version == '3.9' && '--cov aiida' || '' }}
- name: Upload coverage report
if: matrix.python-version == 3.9 && github.repository == 'aiidateam/aiida-core'
Expand All @@ -90,7 +94,6 @@ jobs:
file: ./coverage.xml
fail_ci_if_error: false # don't fail job, if coverage upload fails


tests-presto:

runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion docs/source/reference/command_line.rst
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ Below is a list with all available subcommands.
--broker-host HOSTNAME Hostname for the message broker. [default: 127.0.0.1]
--broker-port INTEGER Port for the message broker. [default: 5672]
--broker-virtual-host TEXT Name of the virtual host for the message broker without
leading forward slash.
leading forward slash. [default: ""]
--repository DIRECTORY Absolute path to the file repository.
--test-profile Designate the profile to be used for running the test
suite only.
Expand Down
2 changes: 1 addition & 1 deletion tests/cmdline/commands/test_rabbitmq.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def test_tasks_revive_without_daemon(run_cli_command):
assert run_cli_command(cmd_rabbitmq.cmd_tasks_revive, raises=True)


@pytest.mark.usefixtures('started_daemon_client')
@pytest.mark.usefixtures('aiida_profile_clean')
def test_revive(run_cli_command, monkeypatch, aiida_code_installed, submit_and_await):
"""Test ``tasks revive``."""
code = aiida_code_installed(default_calc_job_plugin='core.arithmetic.add', filepath_executable='/bin/bash')
Expand Down

0 comments on commit a3ccec9

Please sign in to comment.