-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove arm64 build #776
Remove arm64 build #776
Conversation
be1a44c
to
d800ab9
Compare
d800ab9
to
e038283
Compare
e038283
to
dac6a81
Compare
@unkcpz @superstar54 I need to re-enable the integration tests but otherwise this is good for initial review. Let's get this PR merged before the other. (-400 lines of YAML and configuration!) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
=======================================
Coverage 68.28% 68.28%
=======================================
Files 45 45
Lines 4143 4143
=======================================
Hits 2829 2829
Misses 1314 1314
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b30e003
to
5d768a5
Compare
5d768a5
to
e6edb50
Compare
Tests are back and passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @danielhollas Just one minor request, then good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks! Let's wait tests.
Closes #775
build.json
anddocker-build.hcl
. Image can now be build bydocker build . -t aiidalab/qe:newbuild