use table_widget #1068

superstar54 · 2025-01-09T09:13:33Z

Use the new Table wdiget which supports editing, filtering features.

Supports:

to edit label and description of the job
custom columns by show/hide columns
a quick search bar to find jobs by any visible field.
add exit_status and exit_message

new-calculation-history-page.mp4

codecov · 2025-01-09T09:19:03Z

Codecov Report

Attention: Patch coverage is 62.88660% with 36 lines in your changes missing coverage. Please review.

Project coverage is 68.96%. Comparing base (d89548a) to head (fcd8467).

Files with missing lines	Patch %	Lines
src/aiidalab_qe/app/utils/search_jobs.py	62.88%	36 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
+ Coverage   67.98%   68.96%   +0.98%     
==========================================
  Files         113      113              
  Lines        6734     6764      +30     
==========================================
+ Hits         4578     4665      +87     
+ Misses       2156     2099      -57

Flag	Coverage Δ
python-3.11	`68.96% <62.88%> (+0.98%)`	⬆️
python-3.9	`68.98% <62.88%> (+0.98%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edan-bainglass

Very nice @superstar54! Please see my comments.

calculation_history.ipynb

edan-bainglass · 2025-01-09T14:25:58Z

src/aiidalab_qe/app/utils/search_jobs.py

+STATE_ICONS = {
    "running": "⏳",
    "finished": "✅",
    "excepted": "⚠️",
    "killed": "❌",
 }


I use mostly the same icons in the process tree. Best we agree on an icon set and place it in the common module.

src/aiidalab_qe/app/utils/search_jobs.py

AndresOrtegaGuerrero · 2025-01-09T14:46:54Z

Nice @superstar54 , I was wondering , can #1045 be address in the PR ?

- sentence case - add `children` - format lines

superstar54 · 2025-01-09T16:05:22Z

I was wondering , can #1045 be address in the PR ?

Yes, thanks for pointing out this. I added this feature as shown below:

for more information, see https://pre-commit.ci

superstar54 · 2025-01-09T17:21:59Z

Hi @edan-bainglass , I resolved all your comments except the icons. We can unify the icons later. Please review.

edan-bainglass · 2025-01-09T17:39:43Z

I was wondering , can #1045 be address in the PR ?

Yes, thanks for pointing out this. I added this feature as shown below:

Remember to close #1045 if done 🙏

edan-bainglass · 2025-01-09T17:56:02Z

Header is too much. Keep it as it was before, but sentence case
Page guide button is perfect!
Remove the border from everything. It's not adding anything. If you disagree, make sure to add padding to anything that has a border, otherwise, it's looks too cramped.
I have plenty of jobs. Why none showing up?

superstar54 · 2025-01-10T06:36:21Z

I have plenty of jobs. Why none showing up?

How do you install the table_widget from the repo or use pip? If from repo, you also need to run npm install & npm run build

Hi @edan-bainglass , I have resolved all other issues.

edan-bainglass · 2025-01-10T06:46:31Z

I have plenty of jobs. Why none showing up?

How do you install the table_widget from the repo or use pip? If from repo, you also need to run npm install & npm run build

I'm installing from pypi. I've upgraded to 0.0.2. Still no table showing!

Hi @edan-bainglass , I have resolved all other issues.

Simple header (as we do for all notebook except the app). h1 tag, no CSS class. Maybe add some bottom margin if you want.
We can discuss next week if we want all notebook to carry the banner, but that should be for the next release (or minor release).

Also, I really think you should remove the borders. I also removed the margin from the table component. It is much cleaner without it.

edan-bainglass · 2025-01-10T06:59:07Z

Simple header (as we do for all notebook except the app). h1 tag, no CSS class. Maybe add some bottom margin if you want. We can discuss next week if we want all notebook to carry the banner, but that should be for the next release (or minor release).

Also, I really think you should remove the borders. I also removed the margin from the table component. It is much cleaner without it.

Alternatively, if we do want borders

Styles

Heading: h1 with 15px bottom margin
boxes:
- border: 1px solid lightgray
- padding: 0.5em
properties filter box
- same as above, but also margin: 5px

superstar54 · 2025-01-10T07:43:31Z

We can discuss next week if we want all notebook to carry the banner, but that should be for the next release (or minor release).

agree, we should consider to uniform the page header and footer for all notebooks.

I'm installing from pypi. I've upgraded to 0.0.2. Still no table showing!

Any error in the browser console?

Thanks for for the style suggestion, I have implemented the styles.

edan-bainglass · 2025-01-10T08:36:27Z

We can discuss next week if we want all notebook to carry the banner, but that should be for the next release (or minor release).

agree, we should consider to uniform the page header and footer for all notebooks.

I'm installing from pypi. I've upgraded to 0.0.2. Still no table showing!

Any error in the browser console?

Thanks for for the style suggestion, I have implemented the styles.

Not sure why, but it works now. I can see my jobs. Styles look great! However, I am getting an error.

Filtered by PDOS, then by running job state, and got

---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
/opt/conda/lib/python3.9/site-packages/ipywidgets/widgets/widget.py in _handle_msg(self, msg)
    762                 if 'buffer_paths' in data:
    763                     _put_buffers(state, data['buffer_paths'], msg['buffers'])
--> 764                 self.set_state(state)
    765 
    766         # Handle a state request.

/opt/conda/lib/python3.9/site-packages/ipywidgets/widgets/widget.py in set_state(self, sync_data)
    631                     from_json = self.trait_metadata(name, 'from_json',
    632                                                     self._trait_from_json)
--> 633                     self.set_trait(name, from_json(sync_data[name], self))
    634 
    635     def send(self, content, buffers=None):

/opt/conda/lib/python3.9/contextlib.py in __exit__(self, typ, value, traceback)
    124         if typ is None:
    125             try:
--> 126                 next(self.gen)
    127             except StopIteration:
    128                 return False

~/.local/lib/python3.9/site-packages/traitlets/traitlets.py in hold_trait_notifications(self)
   1500                 for changes in cache.values():
   1501                     for change in changes:
-> 1502                         self.notify_change(change)
   1503 
   1504     def _notify_trait(self, name, old_value, new_value):

/opt/conda/lib/python3.9/site-packages/ipywidgets/widgets/widget.py in notify_change(self, change)
    692                 # Send new state to front-end
    693                 self.send_state(key=name)
--> 694         super(Widget, self).notify_change(change)
    695 
    696     def __repr__(self):

~/.local/lib/python3.9/site-packages/traitlets/traitlets.py in notify_change(self, change)
   1515     def notify_change(self, change):
   1516         """Notify observers of a change event"""
-> 1517         return self._notify_observers(change)
   1518 
   1519     def _notify_observers(self, event):

~/.local/lib/python3.9/site-packages/traitlets/traitlets.py in _notify_observers(self, event)
   1562                 c = getattr(self, c.name)
   1563 
-> 1564             c(event)
   1565 
   1566     def _add_notifiers(self, handler, name, type):

/opt/conda/lib/python3.9/site-packages/ipywidgets/widgets/widget_selection.py in _propagate_index(self, change)
    233             self.label = label
    234         if self.value is not value:
--> 235             self.value = value
    236 
    237     @validate('value')

~/.local/lib/python3.9/site-packages/traitlets/traitlets.py in __set__(self, obj, value)
    730             raise TraitError('The "%s" trait is read-only.' % self.name)
    731         else:
--> 732             self.set(obj, value)
    733 
    734     def _validate(self, obj, value):

~/.local/lib/python3.9/site-packages/traitlets/traitlets.py in set(self, obj, value)
    719             # we explicitly compare silent to True just in case the equality
    720             # comparison above returns something other than True/False
--> 721             obj._notify_trait(self.name, old_value, new_value)
    722 
    723     def __set__(self, obj, value):

~/.local/lib/python3.9/site-packages/traitlets/traitlets.py in _notify_trait(self, name, old_value, new_value)
   1503 
   1504     def _notify_trait(self, name, old_value, new_value):
-> 1505         self.notify_change(
   1506             Bunch(
   1507                 name=name,

/opt/conda/lib/python3.9/site-packages/ipywidgets/widgets/widget.py in notify_change(self, change)
    692                 # Send new state to front-end
    693                 self.send_state(key=name)
--> 694         super(Widget, self).notify_change(change)
    695 
    696     def __repr__(self):

~/.local/lib/python3.9/site-packages/traitlets/traitlets.py in notify_change(self, change)
   1515     def notify_change(self, change):
   1516         """Notify observers of a change event"""
-> 1517         return self._notify_observers(change)
   1518 
   1519     def _notify_observers(self, event):

~/.local/lib/python3.9/site-packages/traitlets/traitlets.py in _notify_observers(self, event)
   1562                 c = getattr(self, c.name)
   1563 
-> 1564             c(event)
   1565 
   1566     def _add_notifiers(self, handler, name, type):

~/apps/quantum-espresso/src/aiidalab_qe/app/utils/search_jobs.py in apply_filters(self, _)
    335                 & (filtered_df["ctime"] <= end_time)
    336             ]
--> 337         self.update_table_value(filtered_df)
    338 
    339     def update_table_visibility(self, _):

~/apps/quantum-espresso/src/aiidalab_qe/app/utils/search_jobs.py in update_table_value(self, display_df)
    291         # Adjust the ID column based on the toggle state
    292         if self.toggle_id_format.value == "PK":
--> 293             display_df = display_df.rename(columns={"PK_with_link": "ID"}).drop(
    294                 columns=["UUID_with_link"]
    295             )

~/.local/lib/python3.9/site-packages/pandas/core/frame.py in drop(self, labels, axis, index, columns, level, inplace, errors)
   5579                 weight  1.0     0.8
   5580         """
-> 5581         return super().drop(
   5582             labels=labels,
   5583             axis=axis,

~/.local/lib/python3.9/site-packages/pandas/core/generic.py in drop(self, labels, axis, index, columns, level, inplace, errors)
   4786         for axis, labels in axes.items():
   4787             if labels is not None:
-> 4788                 obj = obj._drop_axis(labels, axis, level=level, errors=errors)
   4789 
   4790         if inplace:

~/.local/lib/python3.9/site-packages/pandas/core/generic.py in _drop_axis(self, labels, axis, level, errors, only_slice)
   4828                 new_axis = axis.drop(labels, level=level, errors=errors)
   4829             else:
-> 4830                 new_axis = axis.drop(labels, errors=errors)
   4831             indexer = axis.get_indexer(new_axis)
   4832 

~/.local/lib/python3.9/site-packages/pandas/core/indexes/base.py in drop(self, labels, errors)
   7068         if mask.any():
   7069             if errors != "ignore":
-> 7070                 raise KeyError(f"{labels[mask].tolist()} not found in axis")
   7071             indexer = indexer[~mask]
   7072         return self.delete(indexer)

KeyError: "['UUID_with_link'] not found in axis"

superstar54 · 2025-01-10T09:57:28Z

Filtered by PDOS, then by running job state, and got

This is because no result is found, and the pd.dataframe is empty. I fixed it, and it can handle empty data. Besides, I also dropped the usage of pandas because I remember @danielhollas mentioned that he wanted to drop pandas in the AWB. The performance seems not affected.

superstar54 added 2 commits January 9, 2025 09:11

use table_widget

d25a0f8

Merge branch 'main' into use_table_widget

b93ba9c

superstar54 added 2 commits January 9, 2025 12:15

use on_row_update to update label and description

7487061

arrange widgets and udpate guide

30e0629

superstar54 requested review from edan-bainglass and AndresOrtegaGuerrero January 9, 2025 14:20

edan-bainglass requested changes Jan 9, 2025

View reviewed changes

superstar54 added 2 commits January 9, 2025 15:12

implemented review resuggestion.

02a989c

- sentence case - add `children` - format lines

Add exit status and message

eac7275

superstar54 and others added 4 commits January 9, 2025 17:14

Add test

115a403

[pre-commit.ci] auto fixes from pre-commit.com hooks

7da19e2

for more information, see https://pre-commit.ci

update test

58c735f

Add control for the page guid

ed9bdf2

This was linked to issues Jan 9, 2025

Enhance Calculation History with Workflow Error Details #1045

Open

Make the job list page pretty #717

Open

superstar54 requested a review from edan-bainglass January 9, 2025 17:20

Remove logo and use only one border

30b7953

Adjust style as suggestion from review

a1dc8ce

Merge branch 'main' into use_table_widget

0301e6c

Drop pandas and handling empty data

fcd8467

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use table_widget #1068

use table_widget #1068

superstar54 commented Jan 9, 2025 •

edited

Loading

codecov bot commented Jan 9, 2025 •

edited

Loading

edan-bainglass left a comment

edan-bainglass Jan 9, 2025

AndresOrtegaGuerrero commented Jan 9, 2025

superstar54 commented Jan 9, 2025

superstar54 commented Jan 9, 2025 •

edited

Loading

edan-bainglass commented Jan 9, 2025 •

edited

Loading

edan-bainglass commented Jan 9, 2025 •

edited

Loading

superstar54 commented Jan 10, 2025

edan-bainglass commented Jan 10, 2025

edan-bainglass commented Jan 10, 2025

superstar54 commented Jan 10, 2025

edan-bainglass commented Jan 10, 2025

superstar54 commented Jan 10, 2025

use table_widget #1068

Are you sure you want to change the base?

use table_widget #1068

Conversation

superstar54 commented Jan 9, 2025 • edited Loading

codecov bot commented Jan 9, 2025 • edited Loading

Codecov Report

edan-bainglass left a comment

Choose a reason for hiding this comment

edan-bainglass Jan 9, 2025

Choose a reason for hiding this comment

AndresOrtegaGuerrero commented Jan 9, 2025

superstar54 commented Jan 9, 2025

superstar54 commented Jan 9, 2025 • edited Loading

edan-bainglass commented Jan 9, 2025 • edited Loading

edan-bainglass commented Jan 9, 2025 • edited Loading

superstar54 commented Jan 10, 2025

edan-bainglass commented Jan 10, 2025

edan-bainglass commented Jan 10, 2025

Styles

superstar54 commented Jan 10, 2025

edan-bainglass commented Jan 10, 2025

superstar54 commented Jan 10, 2025

superstar54 commented Jan 9, 2025 •

edited

Loading

codecov bot commented Jan 9, 2025 •

edited

Loading

superstar54 commented Jan 9, 2025 •

edited

Loading

edan-bainglass commented Jan 9, 2025 •

edited

Loading

edan-bainglass commented Jan 9, 2025 •

edited

Loading