Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding effect of selecting the table from the structure widget #1061

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

AndresOrtegaGuerrero
Copy link
Member

Added functionality to the structure widget to synchronize the atom table with the selection in the widget.
The widget now supports bidirectional selection behavior: selecting rows in the table updates the widget's selection, and selecting items in the widget updates the table's selection.

Screen.Recording.2025-01-07.at.16.59.28.mov

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 72911d9 into main Jan 7, 2025
11 checks passed
@AndresOrtegaGuerrero AndresOrtegaGuerrero deleted the new_effect_table branch January 7, 2025 16:17
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.87%. Comparing base (f9d5930) to head (7167a68).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pp/result/components/viewer/structure/structure.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1061      +/-   ##
==========================================
- Coverage   67.90%   67.87%   -0.03%     
==========================================
  Files         112      112              
  Lines        6664     6668       +4     
==========================================
+ Hits         4525     4526       +1     
- Misses       2139     2142       +3     
Flag Coverage Δ
python-3.11 67.87% <25.00%> (-0.03%) ⬇️
python-3.9 67.89% <25.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants