-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humanized process status view #1048
base: main
Are you sure you want to change the base?
Humanized process status view #1048
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
+ Coverage 67.99% 69.04% +1.05%
==========================================
Files 113 114 +1
Lines 6734 6995 +261
==========================================
+ Hits 4579 4830 +251
- Misses 2155 2165 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @AndresOrtegaGuerrero. Indeed related. Especially #87, the ideas of which I already had in mind. Though I was wondering if it should be generalized on the AiiDA level. class MyWorkChain(WorkChain):
_humanized_description = "Compute something"
def get_human_readable_description(self):
return self._humanized_description Side question, we are currently on issue 1000+. Do you just happen to remember these ancient issues, or did you go looking? 😅 Asking for my own edification, so I can better find related issues. |
This was an old discussion , so i new Marnik mentioned this in the past, , but indeed there a need of cleaning old issues. |
No doubt! After the release, I plan to go through all issues, close what has not been automatically closed, and prep the agenda for the next release from all that are open. |
src/aiidalab_qe/app/result/components/status/process_tree/tree.py
Outdated
Show resolved
Hide resolved
src/aiidalab_qe/app/result/components/status/process_tree/tree.py
Outdated
Show resolved
Hide resolved
src/aiidalab_qe/app/result/components/status/process_tree/tree.py
Outdated
Show resolved
Hide resolved
src/aiidalab_qe/app/result/components/status/process_tree/tree.py
Outdated
Show resolved
Hide resolved
ececc68
to
86bbf58
Compare
908c45e
to
22dd242
Compare
Is this behaviour expected , Screen.Recording.2025-01-08.at.12.01.42.movIf i go to Generate k-points (since it has a link) it sends me to the Advanced status view .. isnt a lil confusing ? or that is what is required ? |
Intended behavior, but we since discussed changes that address all your comments. Will document here soon. Note that the idea is to implement a couple prior to the release, with the rest (requiring more work) punted down for now. |
735919e
to
cab7963
Compare
2faa2a5
to
765b66f
Compare
This PR implements a simpler process status tree.
The tree is
TODO
Current implementation also marks restart workflows with a *, including a description.
Future PRs will consider dynamic totals.
Component of #1042