Adjust style as suggestion from review

aiidalab · Jan 10, 2025 · a1dc8ce · a1dc8ce
1 parent 30b7953
commit a1dc8ce
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/calculation_history.ipynb b/calculation_history.ipynb
@@ -49,7 +49,9 @@
     "from aiidalab_qe.app.static import templates\n",
     "from aiidalab_qe.common.infobox import InfoBox\n",
     "\n",
-    "title = ipw.HTML(\"<h2 id='subtitle'>🎉 Calculation history 🎉</h2>\")\n",
+    "title = ipw.HTML(\n",
+    "    \"<h1> Calculation history</h1>\", layout=ipw.Layout(margin=\"0 0 15px 0\")\n",
+    ")\n",
     "env = Environment()\n",
     "guide_template = (\n",
     "    files(templates).joinpath(\"calculation_history_guide.jinja\").read_text()\n",

diff --git a/src/aiidalab_qe/app/utils/search_jobs.py b/src/aiidalab_qe/app/utils/search_jobs.py
@@ -232,15 +232,21 @@ def setup_widgets(self):
         self.job_state_dropdown.observe(self.apply_filters, names="value")
         display_options = ipw.VBox(
             children=[
-                ipw.HTML("<h4>Display options:</h4>"),
                 ipw.VBox(
                     children=[
                         self.toggle_time_format,
                         self.toggle_id_format,
                         # self.toggle_multi_selection,
                     ]
                 ),
-                ipw.HTML("<h4>Filters:</h4>"),
+            ],
+            layout=ipw.Layout(
+                border="1px solid lightgray",
+                padding="0.5em",
+            ),
+        )
+        filters = ipw.VBox(
+            children=[
                 ipw.VBox(
                     children=[
                         self.job_state_dropdown,
@@ -251,20 +257,25 @@ def setup_widgets(self):
                                 self.properties_box,
                             ],
                             layout=ipw.Layout(
-                                border="1px solid #ddd",  # fmt: off
+                                border="1px solid lightgray",  # fmt: off
+                                padding="0.5em",
                                 margin="5px",
                             ),
                         ),
                     ]
                 ),
             ],
             layout=ipw.Layout(
-                border="1px solid #ddd",
+                border="1px solid lightgray",
+                padding="0.5em",
             ),
         )
 
         self.main.children = [
+            ipw.HTML("<h4>Display options:</h4>"),
             display_options,
+            ipw.HTML("<h4>Filters:</h4>"),
+            filters,
             self.table,
         ]
         self.update_table_value(self.df)