Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #481

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix integration tests #481

merged 1 commit into from
Jul 18, 2024

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Jul 17, 2024

One of the integration test is currently failing since the new alpha release of AWB because when we uninstall the app do do not uninstall the corresponding python package from the Python environment, leading to a pip check failing in the next test. This is filed as a bug in aiidalab aiidalab/aiidalab#405

FAILED tests/test_aiidalab_apps.py::test_install_apps_from_default_branch[aiidalab-widgets-base]
Command docker compose -f "stack/docker-compose.full-stack.yml" -p "pytest1774" exec -T --user=jovyan 
aiidalab pip check returned 1:
aiidalab-qe 24.10.0a1 has requirement aiidalab-widgets-base[optimade]<2.4.0,~=2.2.0, 
but you have aiidalab-widgets-base 2.3.0a1.

Until that is solved, I modified the fixture to uninstall the pip package corresponding to the App.
(Annoyingly, I needed to special-case aiidalab-qe since the name of the python package aiidalab-qe is different from the name of the app in the registry (quantum-espresso).

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I agree this is a decent workaround. Thanks! @danielhollas
For the package name, it is more a historical reason. I am not sure how many place we need to change and if it going to break something, but we once have an agreement with @yakutovicha and @csadorf we unified to use the name aiidalab-qe in registry (correct me if my memory is wrong).

@danielhollas danielhollas merged commit e6fab3c into main Jul 18, 2024
15 checks passed
@danielhollas danielhollas deleted the fix-integration-tests branch July 18, 2024 15:03
danielhollas added a commit that referenced this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants