add interaction api #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khady
reviewed
Oct 15, 2024
Khady
reviewed
Oct 15, 2024
lib/utils.ml
Outdated
| for handling features such as block actions, shortcuts and modals | ||
| *) | ||
| let process_slack_interaction (ctx : Context.t) headers body ~interaction_handler = | ||
| let payload = Uri.query_of_encoded body |> List.assoc "payload" |> List.hd in |
There was a problem hiding this comment.
List.hd is a code smell. It's better to use a match and fail with a clear message if the list is empty. It also becomes self documented this way
Co-authored-by: Louis <[email protected]>
Khady
force-pushed
the
interactions_api
branch
from
0cade46 to
a012e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add handling of interaction events, aka (shortcuts).
Slack has a different set of webhooks that fire on specific actions such as slash commands and shortcuts. This PR introduces some of the base infrastructure to receive these type of events