Add steps types configs #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates monorobot to allow us to have configs to classify builds steps in defined types, which will allow us to decide on how to handle different types of build steps notifications. For now I just want to update the config to signal the changes being done, and later will add the logic for handling notifications once we agree on it.
I'm not sure sure about the names of the types, but these are likely good enough?
Should this config live inside the allowed pipelines objects? Maybe it makes sense, since monorobot can handle multiple pipelines and repos and maybe we don't want to mix the steps for all of them. This might make automatic generation/update harder.