Clean stale builds from state #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the task
When running tests for the failed builds notifications I've noticed that if for some reason we don't get all the notifications for the events that happen in the followed repo, we will get stale builds. They stay in
pendingstate and are not cleaned because we treat them as if they are still running.This PR handles that issue by setting up a threshold for a build run time and cleaning up builds that passed that threshold.
Considerations
For the time being I have hardcoded a threshold of 2h, only as a value. It's definitely two long, but didn't want to assume 1h straight away.
At the same time, I think it makes sense to add this threshold to the
.monorobotconfig file. I haven't done it because i'd like to discuss first what format we want to have that threshold in.Nothing in these considerations is blocking for this PR to be merged.