Dev notifications config for failed and failing builds #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the task
Extends monorobot config to allow for granular control on failed and failing builds DM notifications.
Adds a new key to the config:
notifications_configs
, where the users can add their own desired configs and commit to update it in real time, since the config file lives in the repo and not on the server.Options are:
dm_for_failing_build
: defaults to true (to match current status rules). Determines wether a developer gets a message for a failing build.dm_after_failed_build
: defaults to false (to match current status rules). Determines wether a developer will get a dm after a failed build. This is independent of thefailed_builds_channel
config.In the end i didn't add tests for this, as it would implicate a lot of overhead for the small (and not complex) change, but maybe in the future we need to consider adding some unit tests with mocks and/or a way to be able to have a default test
.monorobot.json
config and the ability to have custom ones where it is relevant.