Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev notifications config for failed and failing builds #170

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

thatportugueseguy
Copy link
Collaborator

Description of the task

Extends monorobot config to allow for granular control on failed and failing builds DM notifications.

Adds a new key to the config: notifications_configs, where the users can add their own desired configs and commit to update it in real time, since the config file lives in the repo and not on the server.

Options are:

  • dm_for_failing_build: defaults to true (to match current status rules). Determines wether a developer gets a message for a failing build.
  • dm_after_failed_build: defaults to false (to match current status rules). Determines wether a developer will get a dm after a failed build. This is independent of the failed_builds_channel config.

In the end i didn't add tests for this, as it would implicate a lot of overhead for the small (and not complex) change, but maybe in the future we need to consider adding some unit tests with mocks and/or a way to be able to have a default test .monorobot.json config and the ability to have custom ones where it is relevant.

@thatportugueseguy thatportugueseguy merged commit 31bd0d7 into master Dec 30, 2024
0 of 3 checks passed
@thatportugueseguy thatportugueseguy deleted the dev-notifications-config branch December 30, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant